Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2872503003: Add crash keys about field trial shared memory errors. (Closed)
Patch Set: Add TODOs about cleaning up the code. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <windows.h> 9 #include <windows.h>
10 10
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 // Temporary for https://crbug.com/668633. 195 // Temporary for https://crbug.com/668633.
196 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize}, 196 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize},
197 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize}, 197 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize},
198 {"swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize}, 198 {"swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize},
199 {"swdh_set_hosted_version_restart_count", crash_keys::kSmallSize}, 199 {"swdh_set_hosted_version_restart_count", crash_keys::kSmallSize},
200 200
201 // Temporary for https://crbug.com/697745. 201 // Temporary for https://crbug.com/697745.
202 {"engine_params", crash_keys::kMediumSize}, 202 {"engine_params", crash_keys::kMediumSize},
203 {"engine1_params", crash_keys::kMediumSize}, 203 {"engine1_params", crash_keys::kMediumSize},
204 {"engine2_params", crash_keys::kMediumSize}, 204 {"engine2_params", crash_keys::kMediumSize},
205
206 // Temporary for http://crbug.com/703649.
207 {"field_trial_shmem_create_error", crash_keys::kSmallSize},
208 {"field_trial_shmem_map_error", crash_keys::kSmallSize},
205 }; 209 };
206 210
207 // This dynamic set of keys is used for sets of key value pairs when gathering 211 // This dynamic set of keys is used for sets of key value pairs when gathering
208 // a collection of data, like command line switches or extension IDs. 212 // a collection of data, like command line switches or extension IDs.
209 std::vector<base::debug::CrashKey> keys(std::begin(kFixedKeys), 213 std::vector<base::debug::CrashKey> keys(std::begin(kFixedKeys),
210 std::end(kFixedKeys)); 214 std::end(kFixedKeys));
211 215
212 crash_keys::GetCrashKeysForCommandLineSwitches(&keys); 216 crash_keys::GetCrashKeysForCommandLineSwitches(&keys);
213 217
214 // Register the extension IDs. 218 // Register the extension IDs.
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 429
426 return base::RandDouble() < probability; 430 return base::RandDouble() < probability;
427 } 431 }
428 432
429 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 433 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
430 const std::string& process_type) { 434 const std::string& process_type) {
431 // This is not used by Crashpad (at least on Windows). 435 // This is not used by Crashpad (at least on Windows).
432 NOTREACHED(); 436 NOTREACHED();
433 return true; 437 return true;
434 } 438 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698