Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java

Issue 2872473002: Merge ChromeShortcutManager into ShortcutHelper. (Closed)
Patch Set: fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.app.Notification; 7 import android.app.Notification;
8 import android.content.Intent; 8 import android.content.Intent;
9 import android.os.Handler; 9 import android.os.Handler;
10 import android.os.Looper; 10 import android.os.Looper;
(...skipping 20 matching lines...) Expand all
31 import org.chromium.chrome.browser.omaha.RequestGenerator; 31 import org.chromium.chrome.browser.omaha.RequestGenerator;
32 import org.chromium.chrome.browser.physicalweb.PhysicalWebBleClient; 32 import org.chromium.chrome.browser.physicalweb.PhysicalWebBleClient;
33 import org.chromium.chrome.browser.policy.PolicyAuditor; 33 import org.chromium.chrome.browser.policy.PolicyAuditor;
34 import org.chromium.chrome.browser.preferences.LocationSettings; 34 import org.chromium.chrome.browser.preferences.LocationSettings;
35 import org.chromium.chrome.browser.rlz.RevenueStats; 35 import org.chromium.chrome.browser.rlz.RevenueStats;
36 import org.chromium.chrome.browser.services.AndroidEduOwnerCheckCallback; 36 import org.chromium.chrome.browser.services.AndroidEduOwnerCheckCallback;
37 import org.chromium.chrome.browser.signin.GoogleActivityController; 37 import org.chromium.chrome.browser.signin.GoogleActivityController;
38 import org.chromium.chrome.browser.sync.GmsCoreSyncListener; 38 import org.chromium.chrome.browser.sync.GmsCoreSyncListener;
39 import org.chromium.chrome.browser.tab.AuthenticatorNavigationInterceptor; 39 import org.chromium.chrome.browser.tab.AuthenticatorNavigationInterceptor;
40 import org.chromium.chrome.browser.tab.Tab; 40 import org.chromium.chrome.browser.tab.Tab;
41 import org.chromium.chrome.browser.webapps.ChromeShortcutManager;
42 import org.chromium.chrome.browser.webapps.GooglePlayWebApkInstallDelegate; 41 import org.chromium.chrome.browser.webapps.GooglePlayWebApkInstallDelegate;
43 import org.chromium.components.signin.AccountManagerDelegate; 42 import org.chromium.components.signin.AccountManagerDelegate;
44 import org.chromium.components.signin.SystemAccountManagerDelegate; 43 import org.chromium.components.signin.SystemAccountManagerDelegate;
45 import org.chromium.policy.AppRestrictionsProvider; 44 import org.chromium.policy.AppRestrictionsProvider;
46 import org.chromium.policy.CombinedPolicyProvider; 45 import org.chromium.policy.CombinedPolicyProvider;
47 46
48 /** 47 /**
49 * Base class for defining methods where different behavior is required by downs tream targets. 48 * Base class for defining methods where different behavior is required by downs tream targets.
50 * The correct version of {@link AppHooksImpl} will be determined at compile tim e via build rules. 49 * The correct version of {@link AppHooksImpl} will be determined at compile tim e via build rules.
51 * See http://crbug/560466. 50 * See http://crbug/560466.
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 } 106 }
108 107
109 /** 108 /**
110 * Return a {@link AuthenticatorNavigationInterceptor} for the given {@link Tab}. 109 * Return a {@link AuthenticatorNavigationInterceptor} for the given {@link Tab}.
111 * This can be null if there are no applicable interceptor to be built. 110 * This can be null if there are no applicable interceptor to be built.
112 */ 111 */
113 public AuthenticatorNavigationInterceptor createAuthenticatorNavigationInter ceptor(Tab tab) { 112 public AuthenticatorNavigationInterceptor createAuthenticatorNavigationInter ceptor(Tab tab) {
114 return null; 113 return null;
115 } 114 }
116 115
117 /** Returns the singleton instance of ChromeShortcutManager */
118 // TODO(martiw): remove this function after ChromeShortcutManagerInternal is removed
119 public ChromeShortcutManager createChromeShortcutManager() {
120 return new ChromeShortcutManager();
121 }
122
123 /** 116 /**
124 * @return An instance of {@link CustomTabsConnection}. Should not be called 117 * @return An instance of {@link CustomTabsConnection}. Should not be called
125 * outside of {@link CustomTabsConnection#getInstance()}. 118 * outside of {@link CustomTabsConnection#getInstance()}.
126 */ 119 */
127 public CustomTabsConnection createCustomTabsConnection() { 120 public CustomTabsConnection createCustomTabsConnection() {
128 return new CustomTabsConnection(((ChromeApplication) ContextUtils.getApp licationContext())); 121 return new CustomTabsConnection(((ChromeApplication) ContextUtils.getApp licationContext()));
129 } 122 }
130 123
131 /** 124 /**
132 * @return An instance of ExternalAuthUtils to be installed as a singleton. 125 * @return An instance of ExternalAuthUtils to be installed as a singleton.
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 /** 285 /**
293 * @return Whether the renderer should detect whether video elements are in fullscreen. The 286 * @return Whether the renderer should detect whether video elements are in fullscreen. The
294 * detection results can be retrieved through 287 * detection results can be retrieved through
295 * {@link WebContents.hasActiveEffectivelyFullscreenVideo()}. 288 * {@link WebContents.hasActiveEffectivelyFullscreenVideo()}.
296 */ 289 */
297 @CalledByNative 290 @CalledByNative
298 public boolean shouldDetectVideoFullscreen() { 291 public boolean shouldDetectVideoFullscreen() {
299 return false; 292 return false;
300 } 293 }
301 } 294 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698