Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2872453004: cleanup TokenType var names (Closed)

Created:
3 years, 7 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cleanup TokenType var names * rename TokenType info --> type * rename fasta Token.info --> Token.type R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3347169016a18a5039878f11752df64198f7c3b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -148 lines) Patch
M pkg/analyzer/lib/src/dart/scanner/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/token_utils.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 6 chunks +15 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 6 chunks +12 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 7 chunks +21 lines, -21 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/error_token.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/string_scanner.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 20 chunks +42 lines, -53 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/scanner/errors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/precedence_info_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/scanner_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danrubel
3 years, 7 months ago (2017-05-08 15:34:30 UTC) #2
Paul Berry
lgtm
3 years, 7 months ago (2017-05-08 15:36:06 UTC) #4
scheglov
LGTM
3 years, 7 months ago (2017-05-08 15:36:50 UTC) #5
danrubel
Committed patchset #1 (id:1) manually as 3347169016a18a5039878f11752df64198f7c3b8 (presubmit successful).
3 years, 7 months ago (2017-05-08 16:43:19 UTC) #7
ahe
3 years, 6 months ago (2017-05-31 13:28:04 UTC) #8
Message was sent while issue was closed. 
lgtm

FWIW, I try to avoid using the word type when it isn't used for types. My
thinking is that there's one natural thing in a compiler to call a "type" and
nothing else should be called a type.

However, I doubt it would be feasible to change the existing API with respect to
this rule of thumb. I just wanted to mention it, and point out that one can
often use "kind" instead.

Powered by Google App Engine
This is Rietveld 408576698