Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 287243002: Add sanity check to troubleshoot crbug.com/374273 (Closed)

Created:
6 years, 7 months ago by oshima
Modified:
6 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, ananta, luken
Visibility:
Public.

Description

Add sanity check to troubleshoot crbug.com/374273 BUG=374273 R=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
6 years, 7 months ago (2014-05-17 00:22:01 UTC) #1
msw
lgtm. it'd be nice if we cached the images, so we didn't have to retrieve ...
6 years, 7 months ago (2014-05-17 00:31:15 UTC) #2
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-05-17 00:57:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/287243002/1
6 years, 7 months ago (2014-05-17 00:57:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 06:59:56 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 08:14:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154780)
6 years, 7 months ago (2014-05-17 08:14:46 UTC) #7
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-05-17 09:29:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/287243002/1
6 years, 7 months ago (2014-05-17 09:29:28 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 17:12:48 UTC) #10
Message was sent while issue was closed.
Change committed as 271238

Powered by Google App Engine
This is Rietveld 408576698