Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/aura/window_tree_host.cc

Issue 2872343003: Remove InputMethodEventHandler. (Closed)
Patch Set: addressed feedback. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/window_tree_host.h ('k') | ui/events/test/event_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window_tree_host.cc
diff --git a/ui/aura/window_tree_host.cc b/ui/aura/window_tree_host.cc
index 892635705595c75b979ef8476fdf5fe2a5959ccd..15d004042920bd41e20366da9650a97dcc792171 100644
--- a/ui/aura/window_tree_host.cc
+++ b/ui/aura/window_tree_host.cc
@@ -194,7 +194,13 @@ void WindowTreeHost::SetSharedInputMethod(ui::InputMethod* input_method) {
ui::EventDispatchDetails WindowTreeHost::DispatchKeyEventPostIME(
ui::KeyEvent* event) {
- return SendEventToSink(event);
+ // If dispatch to IME is already disabled we shouldn't reach here.
+ DCHECK(!dispatcher_->should_skip_ime());
+ dispatcher_->set_skip_ime(true);
+ ui::EventDispatchDetails dispatch_details = SendEventToSink(event);
+ if (!dispatch_details.dispatcher_destroyed)
+ dispatcher_->set_skip_ime(false);
+ return dispatch_details;
}
void WindowTreeHost::Show() {
« no previous file with comments | « ui/aura/window_tree_host.h ('k') | ui/events/test/event_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698