Chromium Code Reviews Chromium Code Reviews
Issue
2872333002:
Build FreeType with HarfBuzz support (Closed)
DescriptionCompile FreeType with HarfBuzz support
FreeType's autohinter uses HarfBuzz API to collect additional GSUB and
GPOS mappings to detect ligatures that should be aligned by the
autohinter. Previously we were not able to build FreeType with HarfBuzz
support because of the cyclic dependency. This CL resolves the cyclic
dependency by leaving undefined symbols in FreeType and HarfBuzz open
until the linking stage.
This resolves issues with fi and ffi ligatures in Roboto looking like
they were shifted to a different baseline.
I tried developing a pixel test for this, which works if I force usage
of the FreeType autohinter through SkPaint::kSlight_Hinting, however we
are currently unable to automatically test this since our Linux layout
tests do not exercise the autohinting code and do not set this hinting
mode, probably due to the special fontconfig settings that we are using
for the layout tests. Manually verifying the Roboto ligatures however
confirms that this works.
BUG=617168
Patch Set 1 #Patch Set 2 : Add missing gni files #Patch Set 3 : Move back to if statement for harfbuzz-ng-ft target #
Total comments: 1
Patch Set 4 : Move GCC visibility settings into harfbuzz-ng-ft target #Patch Set 5 : Remove duplicate line #Patch Set 6 : Always link harbuzz-ng-ft and fix mac component build #
Messages
Total messages: 31 (26 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
