Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 287233007: Revert of Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
Reviewers:
Peter Kasting, blundell
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (https://codereview.chromium.org/294563002/) Reason for revert: Things cycled green before this revert became active on the testers. Original issue's description: > Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED (https://codereview.chromium.org/284343003/) > > Reason for revert: > speculative, browser_tests stated timing out on all non-dbg win main waterfall test bots, with a message such as > > > E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\scripts\slave\runisolatedtest.py --test_name browser_tests --builder_name "Win7 Tests (1)" --checkout_dir E:\b\build\slave\Win7_Tests__1_\build E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe -- E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.exe --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --lib=browser_tests --gtest_print_time --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9 > > E:\b\depot_tools\python276_bin\python_slave.exe E:\b\build\slave\Win7_Tests__1_\build\src\tools\swarming_client\isolate.py run --isolated E:\b\build\slave\Win7_Tests__1_\build\src\out\Release\browser_tests.isolated -v -- --no-cr --test-launcher-bot-mode --test-launcher-total-shards=3 --test-launcher-shard-index=0 --gtest_output=xml:E:\b\build\slave\Win7_Tests__1_\build\gtest-results\browser_tests\browser_tests.xml --test-launcher-summary-output=c:\users\chrome~2\appdata\local\temp\tmpfbmzn9 > INFO isolate(685): CompleteState.load_isolate(E:\b\build\slave\Win7_Tests__1_\build, E:\b\build\slave\Win7_Tests__1_\build\src\chrome\browser_tests.isolate, {}, {}, {'EXECUTABLE_SUFFIX': '.exe'}, False) > INFO isolate(156): normalize_path_variables(E:\b\build\slave\Win7_Tests__1_\build, {}, E:\b\build\slave\Win7_Tests__1_\build\src\chrome) > INFO isolate_format( 57): determine_root_dir(E:\b\build\slave\Win7_Tests__1_\build\src\chrome, 80 files) -> E:\b\build\slave\Win7_Tests__1_\build\src > INFO isolate( 84): recreate_tree(outdir=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl, indir=E:\b\build\slave\Win7_Tests__1_\build\src, files=9443, action=4, as_hash=False) > INFO isolate(1266): Running ['E:\\b\\depot_tools\\python276_bin\\python_slave.exe', '../testing/test_env.py', u'..\\out\\Release/browser_tests.exe', '--test-launcher-bot-mode', '--no-cr', '--test-launcher-bot-mode', '--test-launcher-total-shards=3', '--test-launcher-shard-index=0', '--gtest_output=xml:E:\\b\\build\\slave\\Win7_Tests__1_\\build\\gtest-results\\browser_tests\\browser_tests.xml', '--test-launcher-summary-output=c:\\users\\chrome~2\\appdata\\local\\temp\\tmpfbmzn9'], cwd=E:\b\build\slave\Win7_Tests__1_\isolate-2014-05-18gqemnl\chrome > > command timed out: 600 seconds without output, attempting to kill > program finished with exit code 1 > > Original issue's description: > > Elimate NOTIFICATION_GOOGLE_URL_UPDATED > > > > This CL moves the remaining client of the NOTIFICATION_GOOGLE_URL_UPDATED > > notification to instead register a callback with GoogleURLTracker and > > eliminates the notification. It also migrate the GoogleURLTracker unittest from > > listening for the notification to listening for the callback. > > > > BUG=373261, 373237 > > TBR=thakis > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271313 > > TBR=pkasting@chromium.org,blundell@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=373261, 373237 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271320 TBR=pkasting@chromium.org,blundell@chromium.org NOTREECHECKS=true NOTRY=true BUG=373261, 373237 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -117 lines) Patch
M chrome/browser/chrome_notification_types.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/google/google_url_tracker.h View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/google/google_url_tracker.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 33 chunks +71 lines, -67 lines 0 comments Download
M chrome/browser/ui/navigation_correction_tab_observer.h View 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/navigation_correction_tab_observer.cc View 3 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Created Revert of Revert of Elimate NOTIFICATION_GOOGLE_URL_UPDATED
6 years, 7 months ago (2014-05-19 01:17:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/287233007/1
6 years, 7 months ago (2014-05-19 01:17:10 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 01:17:52 UTC) #3
Message was sent while issue was closed.
Change committed as 271323

Powered by Google App Engine
This is Rietveld 408576698