Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2872263003: Rename StreamGroup to GroupedEvents. (Closed)

Created:
3 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename StreamGroup to GroupedEvents. Avoids clash with StreamGroup from package:async. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/3f90b06836fca56e72cfadbc7d61590cec79e71c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M sdk/lib/async/stream.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M tests/lib/async/stream_group_by_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-10 12:00:29 UTC) #2
keertip
On 2017/05/10 12:00:29, Lasse Reichstein Nielsen wrote: Thank you!
3 years, 7 months ago (2017-05-10 15:13:12 UTC) #3
floitsch
Lgtm
3 years, 7 months ago (2017-05-10 16:33:45 UTC) #4
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-11 08:53:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f90b06836fca56e72cfadbc7d61590cec79e71c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698