MD Bookmarks: Add 'Open' command, to open in either the BMM or in new tabs

chrome/browser/resources/md_bookmarks/command_manager.js

Index: chrome/browser/resources/md_bookmarks/command_manager.js
diff --git a/chrome/browser/resources/md_bookmarks/command_manager.js b/chrome/browser/resources/md_bookmarks/command_manager.js
index 9cf612ed2bc2ba740a869edab1540906f5929235..211e53db0a3ddeccb88faa8553322993bb3d0b0e 100644
--- a/chrome/browser/resources/md_bookmarks/command_manager.js
+++ b/chrome/browser/resources/md_bookmarks/command_manager.js
@@ -57,6 +57,7 @@ cr.define('bookmarks', function() {
       this.shortcuts_[Command.OPEN_NEW_TAB] =
           cr.isMac ? 'meta+enter' : 'ctrl+enter';
       this.shortcuts_[Command.OPEN_NEW_WINDOW] = 'shift+enter';
+      this.shortcuts_[Command.OPEN] = cr.isMac ? 'meta+down' : 'enter';
     },
 
     detached: function() {
@@ -103,8 +104,13 @@ cr.define('bookmarks', function() {
      * @return {boolean}
      */
     canExecute: function(command, itemIds) {
-      return this.isCommandVisible_(command, itemIds) &&
-          this.isCommandEnabled_(command, itemIds);
+      switch (command) {
+        case Command.OPEN:
+          return itemIds.size > 0;
+        default:
+          return this.isCommandVisible_(command, itemIds) &&
+              this.isCommandEnabled_(command, itemIds);
+      }
     },
 
     /**
@@ -177,6 +183,19 @@ cr.define('bookmarks', function() {
         case Command.OPEN_INCOGNITO:
           this.openUrls_(this.expandUrls_(itemIds), command);
           break;
+        case Command.OPEN:
+          var isFolder = itemIds.size == 1 &&
+              this.containsMatchingNode_(itemIds, function(node) {
+                return !node.url;
+              });
+          if (isFolder) {
+            var folderId = Array.from(itemIds)[0];
+            this.dispatch(bookmarks.actions.selectFolder(
+                folderId, this.getState().nodes));
+          } else {
+            this.openUrls_(this.expandUrls_(itemIds), command);
+          }
+          break;

[calamity, 2017/05/17 05:09:22]

Can we also add a

default:
  assert(false);

here?

[tsergeant, 2017/05/17 07:04:38]

Done.

       }
     },
 
@@ -214,7 +233,7 @@ cr.define('bookmarks', function() {
      */
     openUrls_: function(urls, command) {
       assert(
-          command == Command.OPEN_NEW_TAB ||
+          command == Command.OPEN || command == Command.OPEN_NEW_TAB ||
           command == Command.OPEN_NEW_WINDOW ||
           command == Command.OPEN_INCOGNITO);
 
@@ -225,6 +244,8 @@ cr.define('bookmarks', function() {
       if (command == Command.OPEN_NEW_WINDOW || incognito) {
         chrome.windows.create({url: urls, incognito: incognito});
       } else {
+        if (command == Command.OPEN)
+          chrome.tabs.create({url: urls.shift(), active: true});
         urls.forEach(function(url) {
           chrome.tabs.create({url: url, active: false});
         });