Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: chrome/browser/android/vr_shell/ui_scene_manager.cc

Issue 2872143002: VrShell: Exit fullscreen on app button press. (Closed)
Patch Set: update app button test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/ui_scene_manager.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_manager.cc b/chrome/browser/android/vr_shell/ui_scene_manager.cc
index e59a59a32d9bff92d16b95e437a593c2d6dca1e1..4dca2196c94b0a96e53fed98a21751b0c0a55b2a 100644
--- a/chrome/browser/android/vr_shell/ui_scene_manager.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_manager.cc
@@ -223,15 +223,16 @@ void UiSceneManager::SetWebVrSecureOrigin(bool secure) {
}
void UiSceneManager::OnAppButtonClicked() {
- // App button click exits the WebVR presentation.
+ // App button click exits the WebVR presentation and fullscreen.
browser_->ExitPresent();
+ browser_->ExitFullscreen();
}
void UiSceneManager::OnAppButtonGesturePerformed(
UiInterface::Direction direction) {}
void UiSceneManager::SetFullscreen(bool fullscreen) {
- // Make all VR scene UI elements visible if not in WebVR or fullscreen.
+ // Make all VR scene UI elements visible if not in fullscreen.
for (UiElement* element : browser_ui_elements_) {
element->set_visible(!fullscreen);
}
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698