third_party/WebKit/LayoutTests/PRESUBMIT.py - Issue 2872133011: Change deprecation message of eventSender from error to warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/PRESUBMIT.py

Issue 2872133011: Change deprecation message of eventSender from error to warning (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/LayoutTests/PRESUBMIT.py

diff --git a/third_party/WebKit/LayoutTests/PRESUBMIT.py b/third_party/WebKit/LayoutTests/PRESUBMIT.py

index 1f2e4f361b6814968d013219e7683a0a4bf909af..38e68f056d250867f2400fda8ff460b78df78715 100644

--- a/third_party/WebKit/LayoutTests/PRESUBMIT.py

+++ b/third_party/WebKit/LayoutTests/PRESUBMIT.py

@@ -97,7 +97,7 @@ def _CheckFilesUsingEventSender(input_api, output_api):

if f.Action() == 'A':

for line_num, line in f.ChangedContents():

if any(action in line for action in actions):

- results.append(output_api.PresubmitError(

+ results.append(output_api.PresubmitPromptWarning(

'eventSender is deprecated, please use chrome.gpuBenchmarking.pointerActionSequence instead ' +

'(see https://crbug.com/711340 and http://goo.gl/BND75q).\n' +

'Files: %s:%d %s ' % (f.LocalPath(), line_num, line)))

« no previous file with comments | « no previous file | no next file » | no next file with comments »