Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1922)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 2872133008: Deprecate FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_spdy_stream.cc ('k') | net/tools/quic/quic_simple_server_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 13b22ca5d5afd70182847a0edb3a287d0dca24c7..ca66c54988be71e5804798effcdb14069a220a2e 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -2555,49 +2555,6 @@ TEST_P(EndToEndTest, EarlyResponseFinRecording) {
server_thread_->Resume();
}
-TEST_P(EndToEndTest, LargePostEarlyResponse) {
- const uint32_t kWindowSize = 65536;
- set_client_initial_stream_flow_control_receive_window(kWindowSize);
- set_client_initial_session_flow_control_receive_window(kWindowSize);
- set_server_initial_stream_flow_control_receive_window(kWindowSize);
- set_server_initial_session_flow_control_receive_window(kWindowSize);
-
- ASSERT_TRUE(Initialize());
- if (FLAGS_quic_reloadable_flag_quic_always_enable_bidi_streaming) {
- // This test is testing the same behavior as
- // EarlyResponseWithQuicStreamNoError, except for the additional final check
- // that the stream is reset on early response. Once this flag is deprecated
- // the tests will be the same and this one can be removed.
- return;
- }
-
- EXPECT_TRUE(client_->client()->WaitForCryptoHandshakeConfirmed());
-
- // POST to a URL that gets an early error response, after the headers are
- // received and before the body is received.
- SpdyHeaderBlock headers;
- headers[":method"] = "POST";
- headers[":path"] = "/foo";
- headers[":scheme"] = "https";
- headers[":authority"] = server_hostname_;
- headers["content-length"] = "-1";
-
- // Tell the client to not close the stream if it receives an early response.
- client_->set_allow_bidirectional_data(true);
- // Send the headers.
- client_->SendMessage(headers, "", /*fin=*/false);
-
- // Receive the response and let the server close writing.
- client_->WaitForInitialResponse();
- EXPECT_EQ("500", client_->response_headers()->find(":status")->second);
-
- // Receive the reset stream from server on early response.
- QuicStream* stream = client_->client()->session()->GetOrCreateStream(
- GetNthClientInitiatedId(0));
- // The stream is reset by server's reset stream.
- EXPECT_EQ(stream, nullptr);
-}
-
TEST_P(EndToEndTest, Trailers) {
// Test sending and receiving HTTP/2 Trailers (trailing HEADERS frames).
ASSERT_TRUE(Initialize());
« no previous file with comments | « net/quic/core/quic_spdy_stream.cc ('k') | net/tools/quic/quic_simple_server_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698