Added translation policy API.

ios/web_view/public/cwv_translation_controller.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_VIEW_PUBLIC_CWV_TRANSLATION_CONTROLLER_H
 #define IOS_WEB_VIEW_PUBLIC_CWV_TRANSLATION_CONTROLLER_H
 
 #import <ChromeWebView/cwv_export.h>
 #import <Foundation/Foundation.h>
 
 NS_ASSUME_NONNULL_BEGIN
 
 @class CWVTranslationLanguage;
+@class CWVTranslationPolicy;
 @protocol CWVTranslationControllerDelegate;
 
 // The error domain for translation errors.
 extern NSErrorDomain const CWVTranslationErrorDomain;
 
 // Possible error codes during translation.
 // No connectivity.
 extern const NSInteger CWVTranslationErrorNetwork;
 // The translation script failed to initialize.
 extern const NSInteger CWVTranslationErrorInitializationError;
@@ skipping 33 matching lines @@
                        toLanguage:(CWVTranslationLanguage*)targetLanguage;
 
 // Reverts any translations done back to the original page language.
 // Note that the original page language  may be different from |sourceLanguage|
 // passed to |translatePageFromLanguage:toLanguage:| above.
 // This must not be called before the |delegate| receives
 // |translationController:didFinishLanguageDetectionWithResult:error:|.
 // TODO(crbug.com/706289): Document what happens if you call this out of order.
 - (void)revertTranslation;
 
+// Save or retrieve translation policies associated with a specified language.
+- (void)saveTranslationPolicy:(CWVTranslationPolicy*)policy

[Hiroshi Ichikawa, 2017/05/10 08:36:56]

1. Maybe "set" not "save" to be consistent with standard naming convention of
setters in Obj-C?
2. "language" is unclear, so how about "pageLanguage" instead?
3. Maybe add "for" to the selector to be consistent with
-translationPolicyForLanguage?

Putting all together, my suggestion is to change the selector to:
-setTranslationPolicy:forPageLanguage:

[jzw1, 2017/05/11 03:03:17]

Done.

+                     language:(CWVTranslationLanguage*)language;
+- (CWVTranslationPolicy*)translationPolicyForLanguage:
+    (CWVTranslationLanguage*)language;
+
+// Save or retrieve translation policies associated with a specified page.
+- (void)saveTranslationPolicy:(CWVTranslationPolicy*)policy

[Hiroshi Ichikawa, 2017/05/10 08:36:55]

1. Maybe "set" not "save" to be consistent with standard naming convention of
setters in Obj-C?
2. Maybe add "for" to the selector to be consistent with
-translationPolicyForLanguage?

Putting all together, my suggestion is to change the selector to:
-setTranslationPolicy:forPageHost:

[jzw1, 2017/05/11 03:03:17]

Done.

+                     pageHost:(NSString*)pageHost;
+- (CWVTranslationPolicy*)translationPolicyForPageHost:(NSString*)pageHost;
+
 @end
 
 NS_ASSUME_NONNULL_END
 
 #endif  // IOS_WEB_VIEW_PUBLIC_CWV_TRANSLATION_CONTROLLER_H