Issue 2872034: Add the TokenService to the chrome profile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2872034: Add the TokenService to the chrome profile (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by chron_chromium.org

Modified:
4 years ago

Reviewers:
Chris Masone

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, ben+cc_chromium.org, Raghu Simha, idana, ncarter, darin-cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr., timsteele

Visibility:
Public.

Description

Add the TokenService to the chrome profile, and use it to pass the LSID from ChromiumOS login into Sync. This is just initial groundlaying for replacing the internal sync auth stack. IssueAuthToken is not yet used in this CL. TEST=Run chromium OS. Login using your credentials. Verify that sync works in about:sync. BUG=47093 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52250

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -31 lines)			Patch
M	chrome/browser/chromeos/login/login_utils.cc	View	1 2 3	3 chunks	+4 lines, -1 line	0 comments	Download
A	chrome/browser/net/gaia/token_service.h	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
A	chrome/browser/net/gaia/token_service.cc	View	1 2 3	1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/profile.h	View	1 2 3	4 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/profile.cc	View	1 2 3	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1 2 3	4 chunks	+4 lines, -26 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/testing_profile.h	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/test/testing_profile.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Trybot results: linux linux_chromeos win mac

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

chron_chromium.org

Let me know if there's someone else that should do these CLs if you're too ...

4 years, 10 months ago (2010-07-07 02:24:34 UTC) #1

chron_chromium.org

(sorry misnamed the issue) Let me know if you prefer that someone else review these ...

4 years, 10 months ago (2010-07-07 02:25:45 UTC) #2

Chris Masone

4 years, 10 months ago (2010-07-07 16:19:37 UTC) #3

It might be nice if this passed a few more trybots, but it generally LGTM.  

On 2010/07/07 02:25:45, chron_chromium.org wrote:
> (sorry misnamed the issue)
> 
> Let me know if you prefer that someone else review these if you're busy.

Expand Messages | Collapse Messages

Issue 2872034: Add the TokenService to the chrome profile (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix whitespace #

Patch Set 3 : Unit test fix #

Patch Set 4 : Fixed oops :) #

Messages