Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2872023006: web_audio: rename OfflineAudioContext.suspend (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

web_audio: rename OfflineAudioContext.suspend Rename member to avoid warning due to incompatible signature of base class method of same name. TBR=terry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0879884d80b76c2020220047885be38fbc9f15ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +14 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
Committed patchset #1 (id:1) manually as 0879884d80b76c2020220047885be38fbc9f15ee (presubmit successful).
3 years, 7 months ago (2017-05-12 01:05:20 UTC) #2
terry
3 years, 7 months ago (2017-05-12 13:02:05 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698