[Sync] Add a simple UI to sync-internals to create UserEvents.

chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_internals_message_handler.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 11 matching lines @@
 namespace {
 
 class TestableSyncInternalsMessageHandler : public SyncInternalsMessageHandler {
  public:
   explicit TestableSyncInternalsMessageHandler(
       content::WebUI* web_ui,
       std::unique_ptr<AboutSyncDataExtractor> about_sync_data_extractor)
       : SyncInternalsMessageHandler(std::move(about_sync_data_extractor)) {
     set_web_ui(web_ui);
   }
+
+  void SignalIsInitialized() { AllowJavascript(); }
 };
 
 class FakeExtractor : public AboutSyncDataExtractor {
  public:
   std::unique_ptr<base::DictionaryValue> ConstructAboutInformation(
       syncer::SyncService* service,
       SigninManagerBase* signin) override {
     call_count_++;
     last_service_ = service;
     last_signin_ = signin;
@@ skipping 44 matching lines @@
     ASSERT_TRUE(arg2);
 
     const base::DictionaryValue* root_dictionary = nullptr;
     ASSERT_TRUE(arg2->GetAsDictionary(&root_dictionary));
 
     std::string fake_value;
     EXPECT_TRUE(root_dictionary->GetString("fake_key", &fake_value));
     EXPECT_EQ("fake_value", fake_value);
   }
 
-  SyncInternalsMessageHandler* handler() { return handler_.get(); }
+  void ValidateEmptyAboutInfoCall() {
+    EXPECT_TRUE(web_ui_.call_data().empty());
+  }
+
+  TestableSyncInternalsMessageHandler* handler() { return handler_.get(); }
   FakeExtractor* fake_extractor() { return fake_extractor_; }
 
  private:
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
   content::TestWebUI web_ui_;
   scoped_refptr<content::SiteInstance> site_instance_;
   std::unique_ptr<content::WebContents> web_contents_;
-  std::unique_ptr<SyncInternalsMessageHandler> handler_;
+  std::unique_ptr<TestableSyncInternalsMessageHandler> handler_;
 
   // Non-owning pointer to the about information the handler uses. This
   // extractor is owned by the handler.
   FakeExtractor* fake_extractor_;
 };
 
 }  // namespace
 
+TEST_F(SyncInternalsMessageHandlerTest, SendAboutInfoBeforeInitialized) {
+  handler()->OnStateChanged(nullptr);
+  ValidateEmptyAboutInfoCall();
+}
+
 TEST_F(SyncInternalsMessageHandlerTest, SendAboutInfoWithService) {
+  handler()->SignalIsInitialized();
   handler()->OnStateChanged(nullptr);
   EXPECT_EQ(1, fake_extractor()->call_count());
   EXPECT_NE(nullptr, fake_extractor()->last_service());
   EXPECT_NE(nullptr, fake_extractor()->last_signin());
   ValidateAboutInfoCall();
 }
 
 TEST_F(SyncInternalsMessageHandlerTest, SendAboutInfoWithoutService) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(switches::kDisableSync);
+  handler()->SignalIsInitialized();
   handler()->OnStateChanged(nullptr);
   EXPECT_EQ(1, fake_extractor()->call_count());
   EXPECT_EQ(nullptr, fake_extractor()->last_service());
   EXPECT_EQ(nullptr, fake_extractor()->last_signin());
   ValidateAboutInfoCall();
 }