Issue 2872004: accelerator removal fix in info bubble

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2872004: accelerator removal fix in info bubble (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by oshima

Modified:
3 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Correctly remove accelerator when info bubble is closed. accelerator was not removed when it's closed by escape accelerator. This was causing crash in screen locker. Use "Resume" text for unlock button. Removed unnecessary TextButton dependency in screen_lock_view.h BUG=none TEST=lock screen using ctrl-alt-l, type wrong password and enter then hit escape twice. It will not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50136

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_lock_view.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_lock_view.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/info_bubble.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Trybot results: linux_chromeos win linux linux_view mac

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages