[Chromedriver] Do not pass --verbose in testDisablingDriverLogsSuppressesChromeDriverLog.

chrome/test/chromedriver/server/server.py

Index: chrome/test/chromedriver/server/server.py
diff --git a/chrome/test/chromedriver/server/server.py b/chrome/test/chromedriver/server/server.py
index 2023e2b03e0a8c724f450c11de0dd8534793894a..801e0425910bd8fc3643ec10cffe7850c69362e5 100644
--- a/chrome/test/chromedriver/server/server.py
+++ b/chrome/test/chromedriver/server/server.py
@@ -13,7 +13,7 @@ import urllib2
 class Server(object):
   """A running ChromeDriver server."""
 
-  def __init__(self, exe_path, log_path=None):
+  def __init__(self, exe_path, log_path=None, verbose=True):
     """Starts the ChromeDriver server and waits for it to be ready.
 
     Args:
@@ -27,8 +27,10 @@ class Server(object):
 
     port = self._FindOpenPort()
     chromedriver_args = [exe_path, '--port=%d' % port]
-    if log_path:
-      chromedriver_args.extend(['--verbose', '--log-path=%s' % log_path])
+    if not verbose and log_path:

[johnchen, 2017/05/11 23:37:11]

I would organize the code a little differently, something like

if log_path:
  ...extend([--log-path...
  if verbose:
    ...extend(['--verbose'])

This avoids duplicating the formatting of log-path switch.

[gmanikpure, 2017/05/11 23:42:46]

Thanks for the suggestion, John. I will make the change and send it for review.

[gmanikpure, 2017/05/12 01:29:11]

Done. Please take a look. Thanks.

+      chromedriver_args.extend(['--log-path=%s' %log_path])
+    elif verbose and log_path:
+      chromedriver_args.extend(['--verbose','--log-path=%s' %log_path])
     self._process = subprocess.Popen(chromedriver_args)
     self._url = 'http://127.0.0.1:%d' % port
     if self._process is None: