Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 287193014: Early return in UpdateTouchTransformer for software mirroring mode (Closed)

Created:
6 years, 7 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Early return in UpdateTouchTransformer for software mirroring mode Software mirroring mode is special that display_state is marked as DUAL_EXTENDED but it is doing mirroring. There is only one root window as supposed 2 root windows in the extended mode. Early return in UpdateTouchTransformer() for the software mirroring mode for now so as not to crash chrome. BUG=376459 TEST=arm devices don't crash while switching from extended to mirror mode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ash/touch/touch_transformer_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yufeng Shen (Slow to review)
6 years, 7 months ago (2014-05-22 22:15:56 UTC) #1
oshima
lgtm
6 years, 7 months ago (2014-05-22 22:21:31 UTC) #2
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 7 months ago (2014-05-22 22:21:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/287193014/1
6 years, 7 months ago (2014-05-22 22:22:22 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 06:51:19 UTC) #5
Message was sent while issue was closed.
Change committed as 272414

Powered by Google App Engine
This is Rietveld 408576698