Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 287193013: Revert of Strip anonymous blocks when change in style removes need for them (Closed)

Created:
6 years, 7 months ago by esprehn
Modified:
6 years, 7 months ago
CC:
blink-reviews, chrishtr, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., ojan, rune+blink, mstensho (USE GERRIT)
Visibility:
Public.

Description

Revert of Strip anonymous blocks when change in style removes need for them (https://codereview.chromium.org/253313005/) Reason for revert: Looks like it's causing crashes: CPU Info: GenuineIntel family 6 model 37 stepping 5 ========================================================= Thread 0 CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000720] MAGIC SIGNATURE THREAD 0x557533da [chrome_child.dll -renderblocklinelayout.cpp:166 ] WebCore::RenderBlockFlow::createLineBoxes(WebCore::RenderObject *,WebCore::LineInfo const &,WebCore::InlineBox *) 0x557531b2 [chrome_child.dll -renderblocklinelayout.cpp:267 ] WebCore::RenderBlockFlow::constructLine(WebCore::BidiRunList<WebCore::BidiRun> &,WebCore::LineInfo const &) 0x55752f4b [chrome_child.dll -renderblocklinelayout.cpp:825 ] WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns(unsigned int,WebCore::BidiRunList<WebCore::BidiRun> &,WebCore::InlineIterator const &,WebCore::LineInfo &,WebCore::VerticalPositionCache &,WebCore::BidiRun *,WTF::Vector<WebCore::WordMeasurement,64,WTF::DefaultAllocator> &) 0x5574f44c [chrome_child.dll -renderblocklinelayout.cpp:1016 ] WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange(WebCore::LineLayoutState &,WebCore::BidiResolver<WebCore::InlineIterator,WebCore::BidiRun> &,WebCore::InlineIterator const &,WebCore::BidiStatus const &,unsigned int) 0x5574e3d0 [chrome_child.dll -renderblocklinelayout.cpp:916 ] WebCore::RenderBlockFlow::layoutRunsAndFloats(WebCore::LineLayoutState &) 0x555dff70 [chrome_child.dll -renderblocklinelayout.cpp:1734 ] WebCore::RenderBlockFlow::layoutInlineChildren(bool,WebCore::LayoutUnit &,WebCore::LayoutUnit &,WebCore::LayoutUnit) 0x555d86c1 [chrome_child.dll -renderblockflow.cpp:384 ] WebCore::RenderBlockFlow::layoutBlockFlow(bool,WebCore::LayoutUnit &,WebCore::SubtreeLayoutScope &) 0x555d8049 [chrome_child.dll -renderblockflow.cpp:313 ] WebCore::RenderBlockFlow::layoutBlock(bool) 0x555d7ce4 [chrome_child.dll -renderblock.cpp:1352 ] WebCore::RenderBlock::layout() 0x5575b223 [chrome_child.dll -renderblockflow.cpp:2217 ] WebCore::RenderBlockFlow::insertFloatingObject(WebCore::RenderBox *) 0x555dc43d [chrome_child.dll -renderblockflow.cpp:921 ] WebCore::RenderBlockFlow::layoutBlockChildren(bool,WebCore::SubtreeLayoutScope &,WebCore::LayoutUnit,WebCore::LayoutUnit) [...] 0x555dc45b [chrome_child.dll -renderblockflow.cpp:927 ] WebCore::RenderBlockFlow::layoutBlockChildren(bool,WebCore::SubtreeLayoutScope &,WebCore::LayoutUnit,WebCore::LayoutUnit) 0x555d86cf [chrome_child.dll -renderblockflow.cpp:386 ] WebCore::RenderBlockFlow::layoutBlockFlow(bool,WebCore::LayoutUnit &,WebCore::SubtreeLayoutScope &) 0x555d8049 [chrome_child.dll -renderblockflow.cpp:313 ] WebCore::RenderBlockFlow::layoutBlock(bool) 0x555d7ce4 [chrome_child.dll -renderblock.cpp:1352 ] WebCore::RenderBlock::layout() 0x555d7abc [chrome_child.dll -renderview.cpp:225 ] WebCore::RenderView::layout() 0x555d6ee0 [chrome_child.dll -frameview.cpp:802 ] WebCore::FrameView::performLayout(WebCore::RenderObject *,bool) 0x555997f6 [chrome_child.dll -frameview.cpp:974 ] WebCore::FrameView::layout(bool) 0x554f33b2 [chrome_child.dll -document.cpp:2598 ] WebCore::Document::implicitClose() 0x554f2e10 [chrome_child.dll -frameloader.cpp:467 ] WebCore::FrameLoader::checkCompleted() 0x555f718e [chrome_child.dll -resourcefetcher.cpp:1105 ] WebCore::ResourceFetcher::didLoadResource(WebCore::Resource *) 0x555f6ef6 [chrome_child.dll -resourceloader.cpp:100 ] WebCore::ResourceLoader::releaseResources() 0x555f5dfa [chrome_child.dll -resourceloader.cpp:433 ] WebCore::ResourceLoader::didFinishLoading(blink::WebURLLoader *,double,__int64) 0x555f5ccf [chrome_child.dll -web_url_loader_impl.cc:639 ] content::WebURLLoaderImpl::Context::OnCompletedRequest(int,bool,bool,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::TimeTicks const &,__int64) Original issue's description: > Strip anonymous blocks when change in style removes need for them > > When a block element becomes a float or out of flow we should strip > any anonymous blocks wrapping its inline siblings. > > BUG=331251 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174420 TBR=ojan@chromium.org NOTRY=true BUG=331251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -103 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/block/strip-anonymous-blocks-when-block-child-becomes-float.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/fast/block/strip-anonymous-blocks-when-block-child-becomes-float-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 7 chunks +83 lines, -31 lines 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
esprehn
Created Revert of Strip anonymous blocks when change in style removes need for them
6 years, 7 months ago (2014-05-22 17:14:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/287193013/1
6 years, 7 months ago (2014-05-22 17:15:03 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 17:15:04 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-22 17:15:05 UTC) #4
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 7 months ago (2014-05-22 17:23:15 UTC) #5
esprehn
The CQ bit was unchecked by esprehn@chromium.org
6 years, 7 months ago (2014-05-22 17:23:24 UTC) #6
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 7 months ago (2014-05-22 17:23:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/287193013/1
6 years, 7 months ago (2014-05-22 17:24:57 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 17:25:21 UTC) #9
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-22 17:25:21 UTC) #10
esprehn
6 years, 7 months ago (2014-05-22 17:28:00 UTC) #11
Ugh, Okay I'll manually revert.

Powered by Google App Engine
This is Rietveld 408576698