Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 287193011: Clear EmbeddedWorkerContextClient's thread-local ptr in willDestroyWorkerContext() (Closed)

Created:
6 years, 7 months ago by kinuko
Modified:
6 years, 7 months ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org, dominicc (has gone to gerrit)
Visibility:
Public.

Description

Clear EmbeddedWorkerContextClient's thread-local ptr in willDestroyWorkerContext() Back then EmbeddedWorkerContextClient used to be destroyed on the worker thread when corresponding WorkerGlobalScope's destructed, but after http://crrev.com/262813004 we started to destruct it on main thread (after the worker side termination), so resetting thread-local ptr in the dtor doesn't work (as it runs on main thread). This change clears the thread-local ptr in willDestroyWorkerContext(), where we're sure we're still on the worker thread. BUG=n/a Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272487

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed todo comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kinuko
I think this fix http://crbug.com/375643... PTL
6 years, 7 months ago (2014-05-22 08:46:59 UTC) #1
kinuko
On 2014/05/22 08:46:59, kinuko wrote: > I think this fix http://crbug.com/375643... PTL After some investigation ...
6 years, 7 months ago (2014-05-22 11:50:23 UTC) #2
horo
lgtm
6 years, 7 months ago (2014-05-22 11:50:55 UTC) #3
michaeln
lgtm https://codereview.chromium.org/287193011/diff/1/content/renderer/service_worker/embedded_worker_context_client.cc File content/renderer/service_worker/embedded_worker_context_client.cc (right): https://codereview.chromium.org/287193011/diff/1/content/renderer/service_worker/embedded_worker_context_client.cc#newcode145 content/renderer/service_worker/embedded_worker_context_client.cc:145: // g_worker_client_tls.Pointer()->Get() could return NULL if this context ...
6 years, 7 months ago (2014-05-22 19:23:51 UTC) #4
kinuko
https://codereview.chromium.org/287193011/diff/1/content/renderer/service_worker/embedded_worker_context_client.cc File content/renderer/service_worker/embedded_worker_context_client.cc (right): https://codereview.chromium.org/287193011/diff/1/content/renderer/service_worker/embedded_worker_context_client.cc#newcode145 content/renderer/service_worker/embedded_worker_context_client.cc:145: // g_worker_client_tls.Pointer()->Get() could return NULL if this context On ...
6 years, 7 months ago (2014-05-23 02:47:47 UTC) #5
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 7 months ago (2014-05-23 02:47:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/287193011/20001
6 years, 7 months ago (2014-05-23 02:49:25 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 11:08:23 UTC) #8
Message was sent while issue was closed.
Change committed as 272487

Powered by Google App Engine
This is Rietveld 408576698