Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 287193006: Fix compilation error when building with clang on Linux. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com, rileya1
Visibility:
Public.

Description

Fix compilation error when building with clang on Linux. ../../src/effects/gradients/SkGradientShader.cpp:487:22: error: unused function 'bitsTo16' [-Werror,-Wunused-function] static inline U16CPU bitsTo16(unsigned x, const unsigned bits) { R=bsalomon@google.com TEST=make tests Committed: http://code.google.com/p/skia/source/detail?r=14835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 7 months ago (2014-05-21 21:55:25 UTC) #1
reed1
lgtm
6 years, 7 months ago (2014-05-21 22:23:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/287193006/1
6 years, 7 months ago (2014-05-21 22:25:06 UTC) #3
commit-bot: I haz the power
Change committed as 14835
6 years, 7 months ago (2014-05-21 22:31:02 UTC) #4
reed2
6 years, 7 months ago (2014-05-22 03:19:34 UTC) #5
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/297803010/ by reed@chromium.org.

The reason for reverting is: need to revert this along with reverting the big
unitmapper cl.

Powered by Google App Engine
This is Rietveld 408576698