Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 287193005: [Metrics] Move non-idle notifications from MetricsService to ChromeMetricsServiceClient (Closed)

Created:
6 years, 7 months ago by Ilya Sherman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, blundell
Visibility:
Public.

Description

[Metrics] Move non-idle notifications from MetricsService to ChromeMetricsServiceClient BUG=374207 TEST=none R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272083

Patch Set 1 #

Total comments: 2

Patch Set 2 : break! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -27 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.h View 2 chunks +29 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 3 chunks +52 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 5 chunks +6 lines, -25 lines 0 comments Download
M chrome/browser/metrics/metrics_services_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ilya Sherman
6 years, 7 months ago (2014-05-21 15:30:48 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/287193005/diff/1/chrome/browser/metrics/chrome_metrics_service_client.cc File chrome/browser/metrics/chrome_metrics_service_client.cc (right): https://codereview.chromium.org/287193005/diff/1/chrome/browser/metrics/chrome_metrics_service_client.cc#newcode111 chrome/browser/metrics/chrome_metrics_service_client.cc:111: Add a break;
6 years, 7 months ago (2014-05-21 15:39:22 UTC) #2
Ilya Sherman
https://codereview.chromium.org/287193005/diff/1/chrome/browser/metrics/chrome_metrics_service_client.cc File chrome/browser/metrics/chrome_metrics_service_client.cc (right): https://codereview.chromium.org/287193005/diff/1/chrome/browser/metrics/chrome_metrics_service_client.cc#newcode111 chrome/browser/metrics/chrome_metrics_service_client.cc:111: On 2014/05/21 15:39:23, Alexei Svitkine wrote: > Add a ...
6 years, 7 months ago (2014-05-21 15:40:32 UTC) #3
Alexei Svitkine (slow)
LGTM
6 years, 7 months ago (2014-05-21 15:55:52 UTC) #4
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-21 15:56:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/287193005/20001
6 years, 7 months ago (2014-05-21 19:59:10 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 03:59:21 UTC) #7
Message was sent while issue was closed. 
Change committed as 272083

Powered by Google App Engine
This is Rietveld 408576698