Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 287193004: Use modemmanager::kModemManager1ServiceName DBus service constant. (Closed)

Created:
6 years, 7 months ago by Ben Chan
Modified:
6 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Use modemmanager::kModemManager1ServiceName DBus service constant. modemmanager::kModemManager1 has been deprecated and replaced by modemmanager::kModemManager1ServiceName. See https://chromium-review.googlesource.com/#/c/199602/ for details. BUG=None TEST=Run chromeos_unittests. TEST=Send a SMS to a 3G falco and check that a SMS notification is shown. R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271230

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromeos/dbus/fake_shill_device_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_sms_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ben Chan
6 years, 7 months ago (2014-05-16 20:48:21 UTC) #1
stevenjb
lgtm
6 years, 7 months ago (2014-05-16 21:02:44 UTC) #2
Ben Chan
The CQ bit was checked by benchan@chromium.org
6 years, 7 months ago (2014-05-17 06:59:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/287193004/20001
6 years, 7 months ago (2014-05-17 07:00:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 13:02:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 13:58:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154795)
6 years, 7 months ago (2014-05-17 13:58:42 UTC) #7
Ben Chan
6 years, 7 months ago (2014-05-17 16:59:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r271230 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698