Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3130)

Unified Diff: ash/shelf/shelf_button.cc

Issue 287193002: Remove overrides of HitTestRect() which just return false (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: override View::CanProcessEventsWithinSubtree() Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_button.h ('k') | chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_button.cc
diff --git a/ash/shelf/shelf_button.cc b/ash/shelf/shelf_button.cc
index fb255d7fd893814150850f8090c2dafe248a56e1..e1db5d0355fd0f47cd50ceb5535bc3d7fa34f481 100644
--- a/ash/shelf/shelf_button.cc
+++ b/ash/shelf/shelf_button.cc
@@ -123,9 +123,9 @@ class ShelfButton::BarView : public views::ImageView,
ShelfButtonAnimation::GetInstance()->RemoveObserver(this);
}
- // View
- virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE {
- // Allow Mouse...() messages to go to the parent view.
+ // views::View:
+ virtual bool CanProcessEventsWithinSubtree() const OVERRIDE {
+ // Send events to the parent view for handling.
return false;
}
@@ -201,8 +201,8 @@ ShelfButton::IconView::IconView() : icon_size_(kIconSize) {
ShelfButton::IconView::~IconView() {
}
-bool ShelfButton::IconView::HitTestRect(const gfx::Rect& rect) const {
- // Return false so that ShelfButton gets all the mouse events.
+bool ShelfButton::IconView::CanProcessEventsWithinSubtree() const {
+ // Return false so that events are sent to ShelfView for handling.
return false;
}
« no previous file with comments | « ash/shelf/shelf_button.h ('k') | chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698