chrome/browser/ui/views/payments/credit_card_editor_view_controller.h - Issue 2871873003: [Payments] Fix up field widths in desktop editors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller.h

Issue 2871873003: [Payments] Fix up field widths in desktop editors. (Closed)

Patch Set: addressed comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc ('k') | chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller.h

diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h

index 0238586dff14913e1d6c878b24c9186aa4bffb39..dd69630db1eb6e967761916d548328c6c5e36593 100644

--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h

+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h

@@ -48,7 +48,7 @@ class CreditCardEditorViewController : public EditorViewController {

// EditorViewController:

std::unique_ptr<views::View> CreateHeaderView() override;

- std::unique_ptr<views::View> CreateCustomFieldView(

+ std::unique_ptr<views::View> CreateExtraViewForField(

autofill::ServerFieldType type) override;

std::vector<EditorField> GetFieldDefinitions() override;

base::string16 GetInitialValueForType(