Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: components/autofill/core/browser/address_combobox_model_unittest.cc

Issue 2871873003: [Payments] Fix up field widths in desktop editors. (Closed)
Patch Set: addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/autofill/core/browser/address_combobox_model.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/address_combobox_model.h" 5 #include "components/autofill/core/browser/address_combobox_model.h"
6 6
7 #include "components/autofill/core/browser/autofill_test_utils.h" 7 #include "components/autofill/core/browser/autofill_test_utils.h"
8 #include "components/autofill/core/browser/test_personal_data_manager.h" 8 #include "components/autofill/core/browser/test_personal_data_manager.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/region_dat a.h" 10 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/region_dat a.h"
11 11
12 namespace autofill { 12 namespace autofill {
13 13
14 namespace { 14 namespace {
15 const char kAppLocale[] = "fr-CA"; 15 const char kAppLocale[] = "fr-CA";
16 } 16 }
17 17
18 TEST(AddressComboboxModelTest, Empty) { 18 TEST(AddressComboboxModelTest, Empty) {
19 TestPersonalDataManager test_personal_data_manager; 19 TestPersonalDataManager test_personal_data_manager;
20 20
21 AddressComboboxModel model(test_personal_data_manager, kAppLocale); 21 AddressComboboxModel model(test_personal_data_manager, kAppLocale, "");
22 EXPECT_EQ(1, model.GetItemCount()); 22 EXPECT_EQ(1, model.GetItemCount());
23 EXPECT_FALSE(model.IsItemSeparatorAt(0)); 23 EXPECT_FALSE(model.IsItemSeparatorAt(0));
24 EXPECT_TRUE(model.GetItemIdentifierAt(0).empty()); 24 EXPECT_TRUE(model.GetItemIdentifierAt(0).empty());
25 EXPECT_EQ(-1, model.GetIndexOfIdentifier("Anything")); 25 EXPECT_EQ(-1, model.GetIndexOfIdentifier("Anything"));
26 } 26 }
27 27
28 TEST(AddressComboboxModelTest, OneAddress) { 28 TEST(AddressComboboxModelTest, OneAddress) {
29 TestPersonalDataManager test_personal_data_manager; 29 TestPersonalDataManager test_personal_data_manager;
30 AutofillProfile profile1(test::GetFullProfile()); 30 AutofillProfile profile1(test::GetFullProfile());
31 test_personal_data_manager.AddTestingProfile(&profile1); 31 test_personal_data_manager.AddTestingProfile(&profile1);
32 32
33 AddressComboboxModel model(test_personal_data_manager, kAppLocale); 33 AddressComboboxModel model(test_personal_data_manager, kAppLocale,
34 profile1.guid());
34 EXPECT_EQ(3, model.GetItemCount()); 35 EXPECT_EQ(3, model.GetItemCount());
35 EXPECT_FALSE(model.IsItemSeparatorAt(0)); 36 EXPECT_FALSE(model.IsItemSeparatorAt(0));
36 EXPECT_TRUE(model.IsItemSeparatorAt(1)); 37 EXPECT_TRUE(model.IsItemSeparatorAt(1));
37 EXPECT_TRUE(model.GetItemIdentifierAt(0).empty()); 38 EXPECT_TRUE(model.GetItemIdentifierAt(0).empty());
38 EXPECT_TRUE(model.GetItemIdentifierAt(1).empty()); 39 EXPECT_TRUE(model.GetItemIdentifierAt(1).empty());
39 EXPECT_EQ(-1, model.GetIndexOfIdentifier("Anything")); 40 EXPECT_EQ(-1, model.GetIndexOfIdentifier("Anything"));
40 EXPECT_EQ(profile1.guid(), model.GetItemIdentifierAt(2)); 41 EXPECT_EQ(profile1.guid(), model.GetItemIdentifierAt(2));
41 EXPECT_EQ(2, model.GetIndexOfIdentifier(profile1.guid())); 42 EXPECT_EQ(2, model.GetIndexOfIdentifier(profile1.guid()));
43 EXPECT_EQ(2, model.GetDefaultIndex());
42 } 44 }
43 45
44 TEST(AddressComboboxModelTest, TwoAddresses) { 46 TEST(AddressComboboxModelTest, TwoAddresses) {
45 TestPersonalDataManager test_personal_data_manager; 47 TestPersonalDataManager test_personal_data_manager;
46 AutofillProfile profile1(test::GetFullProfile()); 48 AutofillProfile profile1(test::GetFullProfile());
47 AutofillProfile profile2(test::GetFullProfile2()); 49 AutofillProfile profile2(test::GetFullProfile2());
48 50
49 // Force |profile1| to be shown first in the combobox. 51 // Force |profile1| to be shown first in the combobox.
50 profile1.set_use_count(100); 52 profile1.set_use_count(100);
51 test_personal_data_manager.AddTestingProfile(&profile1); 53 test_personal_data_manager.AddTestingProfile(&profile1);
52 test_personal_data_manager.AddTestingProfile(&profile2); 54 test_personal_data_manager.AddTestingProfile(&profile2);
53 55
54 AddressComboboxModel model(test_personal_data_manager, kAppLocale); 56 AddressComboboxModel model(test_personal_data_manager, kAppLocale,
57 profile2.guid());
55 EXPECT_EQ(4, model.GetItemCount()); 58 EXPECT_EQ(4, model.GetItemCount());
56 EXPECT_FALSE(model.IsItemSeparatorAt(0)); 59 EXPECT_FALSE(model.IsItemSeparatorAt(0));
57 EXPECT_TRUE(model.IsItemSeparatorAt(1)); 60 EXPECT_TRUE(model.IsItemSeparatorAt(1));
58 EXPECT_TRUE(model.GetItemIdentifierAt(0).empty()); 61 EXPECT_TRUE(model.GetItemIdentifierAt(0).empty());
59 EXPECT_TRUE(model.GetItemIdentifierAt(1).empty()); 62 EXPECT_TRUE(model.GetItemIdentifierAt(1).empty());
60 EXPECT_EQ(-1, model.GetIndexOfIdentifier("Anything")); 63 EXPECT_EQ(-1, model.GetIndexOfIdentifier("Anything"));
61 EXPECT_EQ(profile1.guid(), model.GetItemIdentifierAt(2)); 64 EXPECT_EQ(profile1.guid(), model.GetItemIdentifierAt(2));
62 EXPECT_EQ(profile2.guid(), model.GetItemIdentifierAt(3)); 65 EXPECT_EQ(profile2.guid(), model.GetItemIdentifierAt(3));
63 EXPECT_EQ(2, model.GetIndexOfIdentifier(profile1.guid())); 66 EXPECT_EQ(2, model.GetIndexOfIdentifier(profile1.guid()));
64 EXPECT_EQ(3, model.GetIndexOfIdentifier(profile2.guid())); 67 EXPECT_EQ(3, model.GetIndexOfIdentifier(profile2.guid()));
68 EXPECT_EQ(3, model.GetDefaultIndex());
65 } 69 }
66 70
67 TEST(AddressComboboxModelTest, AddAnAddress) { 71 TEST(AddressComboboxModelTest, AddAnAddress) {
68 TestPersonalDataManager test_personal_data_manager; 72 TestPersonalDataManager test_personal_data_manager;
69 AutofillProfile profile1(test::GetFullProfile()); 73 AutofillProfile profile1(test::GetFullProfile());
70 test_personal_data_manager.AddTestingProfile(&profile1); 74 test_personal_data_manager.AddTestingProfile(&profile1);
71 75
72 AddressComboboxModel model(test_personal_data_manager, kAppLocale); 76 AddressComboboxModel model(test_personal_data_manager, kAppLocale, "");
73 EXPECT_EQ(3, model.GetItemCount()); 77 EXPECT_EQ(3, model.GetItemCount());
74 EXPECT_EQ(profile1.guid(), model.GetItemIdentifierAt(2)); 78 EXPECT_EQ(profile1.guid(), model.GetItemIdentifierAt(2));
75 EXPECT_EQ(2, model.GetIndexOfIdentifier(profile1.guid())); 79 EXPECT_EQ(2, model.GetIndexOfIdentifier(profile1.guid()));
76 80
77 AutofillProfile profile2(test::GetFullProfile2()); 81 AutofillProfile profile2(test::GetFullProfile2());
78 int new_profile_index = model.AddNewProfile(profile2); 82 int new_profile_index = model.AddNewProfile(profile2);
79 EXPECT_EQ(3, new_profile_index); 83 EXPECT_EQ(3, new_profile_index);
80 EXPECT_EQ(4, model.GetItemCount()); 84 EXPECT_EQ(4, model.GetItemCount());
81 EXPECT_EQ(profile2.guid(), model.GetItemIdentifierAt(3)); 85 EXPECT_EQ(profile2.guid(), model.GetItemIdentifierAt(3));
82 EXPECT_EQ(3, model.GetIndexOfIdentifier(profile2.guid())); 86 EXPECT_EQ(3, model.GetIndexOfIdentifier(profile2.guid()));
83 87
84 // First profile shouldn't have changed, here the order is guaranteed. 88 // First profile shouldn't have changed, here the order is guaranteed.
85 EXPECT_EQ(profile1.guid(), model.GetItemIdentifierAt(2)); 89 EXPECT_EQ(profile1.guid(), model.GetItemIdentifierAt(2));
86 EXPECT_EQ(2, model.GetIndexOfIdentifier(profile1.guid())); 90 EXPECT_EQ(2, model.GetIndexOfIdentifier(profile1.guid()));
87 } 91 }
88 92
89 } // namespace autofill 93 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/browser/address_combobox_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698