Added histograms on process singleton create when remote process exists and we cannot notify it

chrome/browser/process_singleton.h

Index: chrome/browser/process_singleton.h
diff --git a/chrome/browser/process_singleton.h b/chrome/browser/process_singleton.h
index 96a9bf65f42d2cfab301a10573b25739e7e05a4e..91d86ecaab8eddabf1e86d98d83900534bceb837 100644
--- a/chrome/browser/process_singleton.h
+++ b/chrome/browser/process_singleton.h
@@ -49,6 +49,34 @@ class CommandLine;
 
 class ProcessSingleton : public base::NonThreadSafe {
  public:
+  // Used to send the reason of remote hang process termination as histogram.
+  enum RemoteHungProcessTerminateReason {
+    USER_ACCEPTED_TERMINATION,
+    NO_VISIBLE_WINDOW_FOUND,
+    NOTIFY_ATTEMPTS_EXCEEDED,
+    SOCKET_WRITE_FAILED,
+    SOCKET_READ_FAILED,
+    REMOTE_HUNG_PROCESS_TERMINATE_REASON_COUNT
+  };
+
+  // Used to send the result of interaction with remote process as histograms in
+  // case when remote process influences on start.
+  enum RemoteProcessInteractionResult {
+    TERMINATE_SUCCEEDED,
+    TERMINATE_FAILED,
+    TERMINATE_WAIT_TIMEOUT,
+    TERMINATE_NOT_ENOUGH_PERMISSIONS,
+    REMOTE_PROCESS_SHUTTING_DOWN,
+    PROFILE_UNLOCKED,
+    REMOTE_PROCESS_NOT_FOUND,
+    FAILED_TO_EXTRACT_PID,
+    INVALID_LOCK_FILE,
+    ORPHANED_LOCK_FILE,
+    SAME_BROWSER_INSTANCE,
+    REMOTE_PROCESS_NOTIFY_FAILED,
+    REMOTE_PROCESS_INTERACTION_RESULT_COUNT
+  };

[gab, 2017/05/11 15:10:03]

Split both of these into

enum MyEnum {
#if defined(OS_WIN)
   ...
#elif defined(OS_POSIX)
  ...
#endif
};

since the implementations are mostly orthogonal and don't share many of these?

[Alexey Seren, 2017/05/11 19:18:40]

Acknowledged.

+
   // Logged as histograms, do not modify these values.
   enum NotifyResult {
     PROCESS_NONE = 0,