Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java

Issue 2871753003: [Sync] Speculative changes to address flaky AndroidSyncSettings tests (Closed)
Patch Set: Use assertEquals instead of assertTrue Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java
diff --git a/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java b/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java
index 296980ef014d163acdeb15da64fabfadfdba3b32..4f1cf172b4df913914fa143d5cdfe47a2e9221fa 100644
--- a/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java
+++ b/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java
@@ -251,16 +251,19 @@ public class AndroidSyncSettings {
AccountManagerHelper.get().getGoogleAccounts(new Callback<Account[]>() {
@Override
public void onResult(Account[] accounts) {
- StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskWrites();
- for (Account account : accounts) {
- if (!account.equals(mAccount)
- && mSyncContentResolverDelegate.getIsSyncable(
- account, mContractAuthority)
- > 0) {
- mSyncContentResolverDelegate.setIsSyncable(account, mContractAuthority, 0);
+ synchronized (mLock) {
+ StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskWrites();
+ for (Account account : accounts) {
+ if (!account.equals(mAccount)
+ && mSyncContentResolverDelegate.getIsSyncable(
+ account, mContractAuthority)
+ > 0) {
+ mSyncContentResolverDelegate.setIsSyncable(
+ account, mContractAuthority, 0);
+ }
}
+ StrictMode.setThreadPolicy(oldPolicy);
}
- StrictMode.setThreadPolicy(oldPolicy);
if (callback != null) callback.onResult(true);
}
« no previous file with comments | « no previous file | components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698