third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.cc - Issue 2871733003: [LayoutNG] Refactor NGLineBreaker for ShapingLineBreaker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.cc

Issue 2871733003: [LayoutNG] Refactor NGLineBreaker for ShapingLineBreaker (Closed)

Patch Set: WIP, eae review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/BUILD.gn ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h » ('j') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.cc

index a58aff8eb3b0f4b3c19012f799fb73f3252b7bf6..e9638b4b2814f2b8c63d5704f8de80d296725e6f 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.cc

@@ -13,7 +13,10 @@ NGInlineBreakToken::NGInlineBreakToken(NGInlineNode* node,

unsigned text_offset)

: NGBreakToken(kInlineBreakToken, kUnfinished, node),

item_index_(item_index),

- text_offset_(text_offset) {}

+ text_offset_(text_offset) {

+ // Use nullptr for the initial layout, rather than (0, 0) break token.

+ DCHECK(item_index || text_offset);

NGInlineBreakToken::NGInlineBreakToken(NGLayoutInputNode* node)

: NGBreakToken(kInlineBreakToken, kFinished, node),