third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h - Issue 2871733003: [LayoutNG] Refactor NGLineBreaker for ShapingLineBreaker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h

Issue 2871733003: [LayoutNG] Refactor NGLineBreaker for ShapingLineBreaker (Closed)

Patch Set: WIP Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h

index 850fb691f21f463087c6d9e5ac2efabaa3f9842f..3acec5891a4244d56f38a7e6948e1bd99f9a7de4 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h

@@ -66,6 +66,7 @@ class NGInlineItem {

NGInlineItemType Type() const { return static_cast<NGInlineItemType>(type_); }

const char* NGInlineItemTypeToString(int val) const;

+ const ShapeResult* GetShapeResult() const { return shape_result_.Get(); }

eae 2017/05/10 21:31:38 I've been using the method name TextShapeResult()

kojii 2017/05/11 16:17:36 I like that! ;)

NGLayoutInlineShapeOptions ShapeOptions() const {

return static_cast<NGLayoutInlineShapeOptions>(shape_options_);

}