[LayoutNG] Refactor NGLineBreaker for ShapingLineBreaker

third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NGInlineItemResult_h
+#define NGInlineItemResult_h
+
+#include "core/layout/ng/ng_layout_result.h"
+#include "platform/LayoutUnit.h"
+#include "platform/fonts/shaping/ShapeResult.h"
+
+namespace blink {
+
+// The result of measuring NGInlineItem.
+// Produced while determining the line break points. Data needed to create
+// line boxes are stored in NGInlineItemResults.

[eae, 2017/05/10 21:31:38]

Add a comment explaining that this is a transient context object.

How about marking it as stack allocated?

[kojii, 2017/05/11 16:17:36]

Made DISALLOW_NEW_EXCEPT_PLACEMENT_NEW() to allow a vector of this. Thank you
for pointing out memory-related thing I often forget to take care of.

+struct CORE_EXPORT NGInlineItemResult {
+  unsigned item_index;
+  unsigned start_offset;
+  unsigned end_offset;
+  LayoutUnit inline_size;
+  RefPtr<ShapeResult> shape_result;
+  RefPtr<NGLayoutResult> layout_result;
+
+  NGInlineItemResult();
+  NGInlineItemResult(unsigned index, unsigned start, unsigned end);
+};
+
+using NGInlineItemResults = Vector<NGInlineItemResult, 32>;
+
+}  // namespace blink
+
+#endif  // NGInlineItemResult_h