Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2871683002: [infra] Cleanup buildfile generation scripts a bit (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -36 lines) Patch
M tools/generate_buildfiles.py View 5 chunks +19 lines, -19 lines 0 comments Download
M tools/gn.py View 1 3 chunks +23 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 7 months ago (2017-05-08 17:27:40 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2871683002/diff/1/tools/gn.py File tools/gn.py (right): https://codereview.chromium.org/2871683002/diff/1/tools/gn.py#newcode126 tools/gn.py:126: # clang bugs in inline assembly for ia32 ...
3 years, 7 months ago (2017-05-08 18:04:53 UTC) #3
zra
https://codereview.chromium.org/2871683002/diff/1/tools/gn.py File tools/gn.py (right): https://codereview.chromium.org/2871683002/diff/1/tools/gn.py#newcode126 tools/gn.py:126: # clang bugs in inline assembly for ia32 are ...
3 years, 7 months ago (2017-05-08 18:37:10 UTC) #4
zra
3 years, 7 months ago (2017-05-08 19:31:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0d0d97d7a0629fd043acdf05bcaa34a650cd6847 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698