Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: tools/buildtools/README.md

Issue 2871673003: [infra] Fix clang-format invocation from git cl format (Closed)
Patch Set: Fix for Mac Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/buildtools/linux64/clang-format » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/buildtools/README.md
diff --git a/tools/buildtools/README.md b/tools/buildtools/README.md
new file mode 100644
index 0000000000000000000000000000000000000000..8cd1cfb23dedde8b1bd883d7a43ccff1b0b6aa79
--- /dev/null
+++ b/tools/buildtools/README.md
@@ -0,0 +1,14 @@
+To build Dart for Mac and Linux, we pull Fuchsia's buildtools, which is also
+used by Flutter. Fuchsia's buildtools includes gn, ninja, and the clang
+toolchain. Fuchsia buildtools vends clang-format as part of the clang toolchain.
+Since Fuchsia's buildtools doesn't vend a clang toolchain for Windows, we can't
+get a Windows clang-format binary from it. Therefore, from Chromium's buildtools
+here:
+
+https://chromium.googlesource.com/chromium/buildtools
+
+we copy the hash file for its Windows clang-format binary, and pull it down
+from google storage in the update.py script in this directory.
+
+To update to a newer Windows clang-format binary, simply overwrite the hash in
+clang-format.exe.sha1 with a newer one, and then do a 'gclient sync'.
« no previous file with comments | « no previous file | tools/buildtools/linux64/clang-format » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698