Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2871673003: [infra] Fix clang-format invocation from git cl format (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
rmacnak, aam
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[infra] Fix clang-format invocation from git cl format Instead of maintaining two very similar python scripts, this change copies the binaries they were forwarding to to the location expected by git cl format and depot_tools. R=aam@google.com Committed: https://github.com/dart-lang/sdk/commit/ef139fbef34cbfbce10c3591975f66115e4f1aa4

Patch Set 1 #

Patch Set 2 : Fix for Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -52 lines) Patch
A tools/buildtools/README.md View 1 chunk +14 lines, -0 lines 0 comments Download
D tools/buildtools/linux64/clang-format View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/buildtools/mac/clang-format View 1 chunk +0 lines, -20 lines 0 comments Download
M tools/buildtools/update.py View 1 5 chunks +28 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 7 months ago (2017-05-09 15:17:16 UTC) #2
aam
lgtm LGTM
3 years, 7 months ago (2017-05-09 16:05:11 UTC) #3
zra
Committed patchset #2 (id:20001) manually as ef139fbef34cbfbce10c3591975f66115e4f1aa4 (presubmit successful).
3 years, 7 months ago (2017-05-09 16:24:02 UTC) #5
rmacnak
3 years, 7 months ago (2017-05-09 16:34:47 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698