Source/core/html/HTMLImageElement.cpp - Issue 287163010: Notify <picture> elements when a media query (potentially) changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLImageElement.cpp

Issue 287163010: Notify <picture> elements when a media query (potentially) changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/HTMLImageElement/image-picture-react-to-media-changes.html ('K') | « LayoutTests/fast/dom/HTMLImageElement/image-picture-react-to-media-changes-expected.txt ('k') | Source/core/html/HTMLSourceElement.h » ('j') | Source/core/html/HTMLSourceElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLImageElement.cpp

diff --git a/Source/core/html/HTMLImageElement.cpp b/Source/core/html/HTMLImageElement.cpp

index f295f15850d1ad8127b732b53c4eab80fb8bc8b7..42284dad9ce7057d9197d4d93ed4e9993bcca952 100644

--- a/Source/core/html/HTMLImageElement.cpp

+++ b/Source/core/html/HTMLImageElement.cpp

@@ -243,12 +243,8 @@ ImageCandidate HTMLImageElement::findBestFitImageFromPictureParent()

if (!type.isEmpty() && !supportedImageType(type))

continue;

- String media = source->fastGetAttribute(mediaAttr);

- if (!media.isEmpty()) {

- RefPtrWillBeRawPtr<MediaQuerySet> mediaQueries = MediaQuerySet::create(media);

- if (!document().mediaQueryMatcher().evaluate(mediaQueries.get()))

- continue;

- }

+ if (!source->mediaQueryMatches())

+ continue;

unsigned effectiveSize = SizesAttributeParser::findEffectiveSize(source->fastGetAttribute(sizesAttr), MediaValuesDynamic::create(document()));

ImageCandidate candidate = bestFitSourceForSrcsetAttribute(document().devicePixelRatio(), effectiveSize, source->fastGetAttribute(srcsetAttr));