LayoutTests/fast/hidpi/image-srcset-react-to-media-changes.html - Issue 287163010: Notify <picture> elements when a media query (potentially) changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/hidpi/image-srcset-react-to-media-changes.html

Issue 287163010: Notify <picture> elements when a media query (potentially) changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Yoav Weiss 2014/07/02 18:46:05 Can you change the file name into saying "picture" Can you change the file name into saying "picture" and move it into fast/dom/HTMLImageElement with the other picture/sizes tests? I know that the srcset 'x' descriptor tests are here, but that's a historical mistake that I'd need to remedy one day.
	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 var jsTestIsAsync = true;

	5 var img;

	6

	7 function runTest() {

	8 var iframe = document.getElementById("f");
	Yoav Weiss 2014/07/02 18:46:05 I think most layout tests have a 4 space indent. I think most layout tests have a 4 space indent.
	9 var iframeDoc = iframe.contentWindow.document;

	10

	11 iframeDoc.body.innerHTML = '<picture id="pic">' +

	12 '<source media="(max-width: 90px)" srcset="resources/blue-100-px-square.png" ></source>' +

	13 '<source media="(max-width: 120px)" srcset="resources/green-400-px-square.pn g"></source>' +

	14 '</picture>';

	15

	16 img = iframeDoc.createElement('img');

	17

	18 var first = true;

	19 img.onload = function() {

	20 if (first) {

	21 shouldNotBe('-1', 'img.currentSrc.indexOf("green-400")');

	22 iframe.style.width = "80px";

	23 } else {

	24 shouldNotBe('-1', 'img.currentSrc.indexOf("blue-100")');

	25 finishJSTest();

	26 }

	27 first = false;
	Yoav Weiss 2014/07/02 18:46:05 A nit, but the assignment to first can move up int A nit, but the assignment to first can move up into the if
	28 };

	29 img.onerror = function() {

	30 testFailed('Image should have loaded');

	31 };

	32 iframeDoc.getElementById('pic').appendChild(img);

	33 }

	34 </script>

	35

	36 <body onload="runTest()">

	37 <iframe id="f" style="width: 100px;"></iframe>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/hidpi/image-srcset-react-to-media-changes-expected.txt » ('j') | no next file with comments »