Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2871583002: Pass InterceptorData through ResolutionWorldBuilder and access it through ClosedWorld (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass InterceptorData through ResolutionWorldBuilder and access it through ClosedWorld R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/c4cef519eaf78b7c507bb4048a43a946fae919ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -136 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 3 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/frontend_strategy.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 10 chunks +12 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/interceptor_data.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 3 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 2 chunks +4 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 3 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 4 chunks +1 line, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 5 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 4 chunks +2 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 2 chunks +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 3 chunks +10 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-08 14:25:13 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-08 22:26:41 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-09 08:02:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c4cef519eaf78b7c507bb4048a43a946fae919ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698