Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2871573007: Skip constructors from ElementEnvironment.forEachClassMember (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip constructors from ElementEnvironment.forEachClassMember - and don't mixin static members R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/5e5aa2ea9e372776db7e5b1803d488410eb0c8e8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-09 14:09:26 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2871573007/diff/1/tests/compiler/dart2js/kernel/closed_world2_test.dart File tests/compiler/dart2js/kernel/closed_world2_test.dart (right): https://codereview.chromium.org/2871573007/diff/1/tests/compiler/dart2js/kernel/closed_world2_test.dart#newcode294 tests/compiler/dart2js/kernel/closed_world2_test.dart:294: env2.forEachClassMember(cls2, eek!
3 years, 7 months ago (2017-05-09 18:10:56 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-10 07:53:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5e5aa2ea9e372776db7e5b1803d488410eb0c8e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698