Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/front_end/test/incremental_kernel_generator_test.dart

Issue 2871573003: Update DeltaProgram API and documentation. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/test/incremental_kernel_generator_test.dart
diff --git a/pkg/front_end/test/incremental_kernel_generator_test.dart b/pkg/front_end/test/incremental_kernel_generator_test.dart
index 4b4df84d14494fc7adc54d7db1e561919bfa3ded..ee884f2d72c5b35e66cdd84f1a09b709622f3a93 100644
--- a/pkg/front_end/test/incremental_kernel_generator_test.dart
+++ b/pkg/front_end/test/incremental_kernel_generator_test.dart
@@ -28,11 +28,8 @@ class IncrementalKernelGeneratorTest {
/// The object under test.
IncrementalKernelGenerator incrementalKernelGenerator;
- /// TODO(scheglov) Why do we return a Map?
- /// From the discussion yesterday it seems to me that we always have
- /// just one program - with all libraries with code, or with some libraries
- /// with code and some with only outlines.
- Future<Map<Uri, Program>> getInitialState(Uri entryPoint) async {
+ /// Compute the initial [Program] for the given [entryPoint].
+ Future<Program> getInitialState(Uri entryPoint) async {
Map<String, Uri> dartLibraries = createSdkFiles(fileSystem);
// TODO(scheglov) Builder the SDK kernel and set it into the options.
@@ -46,7 +43,7 @@ class IncrementalKernelGeneratorTest {
..chaseDependencies = true
..dartLibraries = dartLibraries
..packagesFileUri = Uri.parse('file:///test/.packages'));
- return (await incrementalKernelGenerator.computeDelta()).newState;
+ return (await incrementalKernelGenerator.computeDelta()).newProgram;
}
test_updateEntryPoint() async {
@@ -62,10 +59,8 @@ main() {
// Compute the initial state
{
- Map<Uri, Program> initialState = await getInitialState(uri);
- expect(initialState.keys, unorderedEquals([uri]));
-
- Library library = _getLibrary(initialState[uri], uri);
+ Program program = await getInitialState(uri);
+ Library library = _getLibrary(program, uri);
expect(
_getLibraryText(library),
r'''
@@ -91,9 +86,8 @@ main() {
// The delta has the updated entry point library.
{
DeltaProgram delta = await incrementalKernelGenerator.computeDelta();
- expect(delta.newState.keys, unorderedEquals([uri]));
-
- Library library = _getLibrary(delta.newState[uri], uri);
+ Program program = delta.newProgram;
+ Library library = _getLibrary(program, uri);
expect(
_getLibraryText(library),
r'''

Powered by Google App Engine
This is Rietveld 408576698