Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2671)

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc

Issue 2871573002: Disabling "CertificateReportingServiceBrowserTest.DontSendOldReports" on Mac and Win (flaky) (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
diff --git a/chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc b/chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
index dbe29ea07993c81bc20776e957c447b5c4255ade..cfdd6ff4369787b20fb57855b13e1395634e6c3e 100644
--- a/chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
+++ b/chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
@@ -12,6 +12,7 @@
#include "base/test/thread_test_helper.h"
#include "base/time/clock.h"
#include "base/time/time.h"
+#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/safe_browsing/certificate_reporting_service_factory.h"
#include "chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h"
@@ -384,9 +385,15 @@ IN_PROC_BROWSER_TEST_F(CertificateReportingServiceBrowserTest,
ReportExpectation::Successful({{"report1", RetryStatus::RETRIED}}));
}
+// Failing on some Win and Mac buildbots. See crbug.com/719138.
+#if defined(OS_WIN) || defined(OS_MACOSX)
+#define MAYBE_DontSendOldReports DISABLED_DontSendOldReports
+#else
+#define MAYBE_DontSendOldReports DontSendOldReports
+#endif
// CertificateReportingService should ignore reports older than the report TTL.
IN_PROC_BROWSER_TEST_F(CertificateReportingServiceBrowserTest,
- DontSendOldReports) {
+ MAYBE_DontSendOldReports) {
SetExpectedHistogramCountOnTeardown(5);
base::SimpleTestClock* clock = new base::SimpleTestClock();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698