Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.h

Issue 287153006: Pepper: Manifest refactoring in trusted plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/private/ppb_nacl_private.h ('k') | ppapi/native_client/src/trusted/plugin/plugin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/plugin.h
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.h b/ppapi/native_client/src/trusted/plugin/plugin.h
index cb958bce64acb5f0d672d35d716da2b63c067f8b..be366c57fa1cbb43d98d2595a043d7eeed965f5b 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.h
+++ b/ppapi/native_client/src/trusted/plugin/plugin.h
@@ -183,9 +183,6 @@ class Plugin : public pp::Instance {
// Histogram helper functions, internal to Plugin so they can use
// uma_interface_ normally.
void HistogramTimeSmall(const std::string& name, int64_t ms);
- void HistogramTimeMedium(const std::string& name, int64_t ms);
- void HistogramTimeLarge(const std::string& name, int64_t ms);
- void HistogramSizeKB(const std::string& name, int32_t sample);
void HistogramEnumerateLoadStatus(PP_NaClError error_code);
void HistogramEnumerateSelLdrLoadStatus(NaClErrorCode error_code);
@@ -250,13 +247,6 @@ class Plugin : public pp::Instance {
// Processes the JSON manifest string and starts loading the nexe.
void ProcessNaClManifest(const nacl::string& manifest_json);
- // Parses the JSON in |manifest_json| and retains a Manifest in
- // |manifest_| for use by subsequent resource lookups.
- // On success, |true| is returned and |manifest_| is updated to
- // contain a Manifest that is used by SelectNexeURLFromManifest.
- // On failure, |false| is returned, and |manifest_| is unchanged.
- bool SetManifestObject(const nacl::string& manifest_json);
-
// Logs timing information to a UMA histogram, and also logs the same timing
// information divided by the size of the nexe to another histogram.
void HistogramStartupTimeSmall(const std::string& name, float dt);
@@ -311,7 +301,6 @@ class Plugin : public pp::Instance {
int64_t time_of_last_progress_event_;
int exit_status_;
- PP_Var manifest_data_var_;
int32_t manifest_id_;
PP_FileHandle nexe_handle_;
« no previous file with comments | « ppapi/c/private/ppb_nacl_private.h ('k') | ppapi/native_client/src/trusted/plugin/plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698