MD Settings: Network: Do not call setProperties when setting defaults

chrome/browser/resources/settings/internet_page/internet_detail_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-internet-detail' is the settings subpage containing details
  * for a network.
  */
 (function() {
@@ skipping 127 matching lines @@
   },
 
   /**
    * Listener function for chrome.networkingPrivate.onNetworksChanged event.
    * @type {?function(!Array<string>)}
    * @private
    */
   networksChangedListener_: null,
 
   /**
+   * Set to true to once the initial properties have been received. This
+   * prevents setProperties from being called when setting default properties.
+   * @private {boolean}
+   */
+  networkPropertiesReceived_: false,
+
+  /**
    * settings.RouteObserverBehavior
    * @param {!settings.Route} route
    * @protected
    */
   currentRouteChanged: function(route) {
     if (route != settings.Route.NETWORK_DETAIL) {
       if (this.networksChangedListener_) {
         this.networkingPrivate.onNetworksChanged.removeListener(
             this.networksChangedListener_);
         this.networksChangedListener_ = null;
       }
       return;
     }
     if (!this.networksChangedListener_) {
       this.networksChangedListener_ = this.onNetworksChangedEvent_.bind(this);
       this.networkingPrivate.onNetworksChanged.addListener(
           this.networksChangedListener_);
     }
     var queryParams = settings.getQueryParameters();
     this.guid = queryParams.get('guid') || '';
     if (!this.guid) {
       console.error('No guid specified for page:' + route);
       this.close_();
     }
     // Set basic networkProperties until they are loaded.
+    this.networkPropertiesReceived_ = false;
     var type = /** @type {!chrome.networkingPrivate.NetworkType} */ (
                    queryParams.get('type')) ||
         CrOnc.Type.WI_FI;
     var name = queryParams.get('name') || type;
     this.networkProperties = {
       GUID: this.guid,
       Type: type,
       ConnectionState: CrOnc.ConnectionState.NOT_CONNECTED,
       Name: {Active: name},
     };
@@ skipping 95 matching lines @@
       }
       this.close_();
       return;
     }
     if (!properties) {
       console.error('No properties for: ' + this.guid);
       this.close_();
       return;
     }
     this.networkProperties = properties;
+    this.networkPropertiesReceived_ = true;
   },
 
   /**
    * networkingPrivate.getState callback.
    * @param {CrOnc.NetworkStateProperties} state The network state properties.
    * @private
    */
   getStateCallback_: function(state) {
     if (!state) {
       // If |state| is null, the network is no longer visible, close this.
       console.error('Network no longer exists: ' + this.guid);
       this.networkProperties = undefined;
       this.close_();
     }
     this.networkProperties = {
       GUID: state.GUID,
       Type: state.Type,
       Connectable: state.Connectable,
       ConnectionState: state.ConnectionState,
     };
+    this.networkPropertiesReceived_ = true;
   },
 
   /**
    * @param {!chrome.networkingPrivate.NetworkConfigProperties} onc The ONC
    *     network properties.
    * @private
    */
   setNetworkProperties_: function(onc) {
+    if (!this.networkPropertiesReceived_)
+      return;
+
     assert(!!this.guid);
     this.networkingPrivate.setProperties(this.guid, onc, function() {
       if (chrome.runtime.lastError) {
         // An error typically indicates invalid input; request the properties
         // to update any invalid fields.
         this.getNetworkDetails_();
       }
     }.bind(this));
   },
 
@@ skipping 600 matching lines @@
    */
   allPropertiesMatch_: function(curValue, newValue) {
     for (var key in newValue) {
       if (newValue[key] != curValue[key])
         return false;
     }
     return true;
   }
 });
 })();