Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2098)

Unified Diff: content/shell/renderer/shell_content_renderer_client.cc

Issue 2871523002: Use OnceCallback on Mojo interfaces in //content (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/shell_content_renderer_client.cc
diff --git a/content/shell/renderer/shell_content_renderer_client.cc b/content/shell/renderer/shell_content_renderer_client.cc
index 89545fff5a16e395d2d68d6118530856db13ae9e..271da8b3a24a3fd07c880b5b5d99ca9bc532ac31 100644
--- a/content/shell/renderer/shell_content_renderer_client.cc
+++ b/content/shell/renderer/shell_content_renderer_client.cc
@@ -55,7 +55,7 @@ class TestServiceImpl : public mojom::TestService {
void OnConnectionError() { delete this; }
// mojom::TestService:
- void DoSomething(const DoSomethingCallback& callback) override {
+ void DoSomething(DoSomethingCallback callback) override {
// Instead of responding normally, unbind the pipe, write some garbage,
// and go away.
const std::string kBadMessage = "This is definitely not a valid response!";
@@ -69,20 +69,18 @@ class TestServiceImpl : public mojom::TestService {
OnConnectionError();
}
- void DoTerminateProcess(const DoTerminateProcessCallback& callback) override {
+ void DoTerminateProcess(DoTerminateProcessCallback callback) override {
NOTREACHED();
}
- void CreateFolder(const CreateFolderCallback& callback) override {
- NOTREACHED();
- }
+ void CreateFolder(CreateFolderCallback callback) override { NOTREACHED(); }
- void GetRequestorName(const GetRequestorNameCallback& callback) override {
- callback.Run("Not implemented.");
+ void GetRequestorName(GetRequestorNameCallback callback) override {
+ std::move(callback).Run("Not implemented.");
}
void CreateSharedBuffer(const std::string& message,
- const CreateSharedBufferCallback& callback) override {
+ CreateSharedBufferCallback callback) override {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698