third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h - Issue 2871513002: Worklet: Lazily create PaintWorkletGlobalScopes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h

Issue 2871513002: Worklet: Lazily create PaintWorkletGlobalScopes (Closed)

Patch Set: fix wrong dcheck Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp ('k') | third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h

diff --git a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h

index df1a68dc0f8560383ed88f48086fb13b2b8550a7..486c9369bb796d9e833a631ae8baad225eed44d0 100644

--- a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h

+++ b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h

@@ -21,7 +21,8 @@ class MODULES_EXPORT PaintWorkletGlobalScopeProxy

public:

static PaintWorkletGlobalScopeProxy* From(WorkletGlobalScopeProxy*);

- explicit PaintWorkletGlobalScopeProxy(LocalFrame*);

+ PaintWorkletGlobalScopeProxy(LocalFrame*,

+ PaintWorkletPendingGeneratorRegistry*);

virtual ~PaintWorkletGlobalScopeProxy() = default;

// Implements WorkletGlobalScopeProxy.

@@ -32,7 +33,6 @@ class MODULES_EXPORT PaintWorkletGlobalScopeProxy

void TerminateWorkletGlobalScope() override;

CSSPaintDefinition* FindDefinition(const String& name);

- void AddPendingGenerator(const String& name, CSSPaintImageGeneratorImpl*);

PaintWorkletGlobalScope* global_scope() const { return global_scope_.Get(); }