Worklet: Lazily create PaintWorkletGlobalScopes

third_party/WebKit/Source/core/workers/MainThreadWorklet.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MainThreadWorklet_h
 #define MainThreadWorklet_h
 
 #include "core/workers/Worklet.h"
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "core/CoreExport.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
 class LocalFrame;
 class ScriptPromiseResolver;
+class WorkletGlobalScopeProxy;
 
 // A MainThreadWorklet is a worklet that runs only on the main thread.
 // TODO(nhiroki): This is a temporary class to support module loading for main
 // thread worklets. This and ThreadedWorklet will be merged into the base
 // Worklet class once threaded worklets are ready to use module loading.
 class CORE_EXPORT MainThreadWorklet : public Worklet {
   USING_GARBAGE_COLLECTED_MIXIN(MainThreadWorklet);
   WTF_MAKE_NONCOPYABLE(MainThreadWorklet);
 
  public:
   virtual ~MainThreadWorklet() = default;
 
   // Worklet
   ScriptPromise addModule(ScriptState*, const String& module_url) final;
 
   // ContextLifecycleObserver
   void ContextDestroyed(ExecutionContext*) final;
 
   DECLARE_VIRTUAL_TRACE();
 
  protected:
   explicit MainThreadWorklet(LocalFrame*);
 
+  // Creates WorkletGlobalScope and adds it into |global_scope_proxies_| if
+  // there are not global scopes or additional global scopes are necessary.
+  virtual void AddWorkletGlobalScopesIfNeeded() = 0;

[kouhei (in TOK), 2017/05/08 13:13:19]

Can we have a virtual WorkletGlobalScopeProxy* CreateWorkletGlobalScope() = 0;
instead and have AddWorkletGlobalScopesIfNeeded + global_scope_proxies_
non-virtual?
This is based on assumption that every AddWorkletGlobalScopesIfNeeded will
actually global_scope_proxies_.insert(std::move(proxy)) at the end.

[nhiroki, 2017/05/10 09:01:31]

Replaced this with NeedsToCreateGlobalScope() and CreateGlobalScope().

+
+  // "A Worklet has a list of the worklet's WorkletGlobalScopes. Initially this
+  // list is empty; it is populated when the user agent chooses to create its
+  // WorkletGlobalScope."
+  // https://drafts.css-houdini.org/worklets/#worklet-section
+  // TODO(nhiroki): Make (Paint)WorkletGlobalScopeProxy GC-managed object to
+  // avoid that GC graphs are disjointed (PaintWorkletGlobalScopeProxy has a
+  // persistent holder for PaintWorkletGlobalscope).

[kouhei (in TOK), 2017/05/08 13:13:19]

+1. Can we give a crbug # to this?

[nhiroki, 2017/05/10 09:01:31]

Added a crbug link.

+  WTF::HashSet<std::unique_ptr<WorkletGlobalScopeProxy>> global_scope_proxies_;
+
  private:
   void FetchAndInvokeScript(const KURL& module_url_record,
                             ScriptPromiseResolver*);
 };
 
 }  // namespace blink
 
 #endif  // MainThreadWorklet_h