Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java

Issue 2871483004: Remove Overflow menu and snackbar when infobar is closing. (Closed)
Patch Set: fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java
index 3ad465956a1447102e13a39d83e0babc60a9f787..13a01ffb766fc35e4699ca95b6767b3e48648a10 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java
@@ -161,6 +161,7 @@ public abstract class InfoBar implements InfoBarView {
mIsDismissed = true;
if (!mContainer.hasBeenDestroyed()) {
// If the container was destroyed, it's already been emptied of all its infobars.
+ onStartedHiding();
mContainer.removeInfoBar(this);
}
return true;
@@ -168,6 +169,12 @@ public abstract class InfoBar implements InfoBarView {
return false;
}
+ /**
+ * Called just before the Java infobar has begun hiding. Give the chance to clean up any child
+ * UI that may remain open.
+ */
+ protected void onStartedHiding() {}
+
long getNativeInfoBarPtr() {
return mNativeInfoBarPtr;
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698