Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java |
| index 3ad465956a1447102e13a39d83e0babc60a9f787..db41440b95c513faa54d48ca7229e95d34484993 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java |
| @@ -161,6 +161,7 @@ public abstract class InfoBar implements InfoBarView { |
| mIsDismissed = true; |
| if (!mContainer.hasBeenDestroyed()) { |
| // If the container was destroyed, it's already been emptied of all its infobars. |
| + onStartedRemoving(); |
|
mdjones
2017/05/11 17:08:24
I'd prefer this be named "onStartedHiding" despite
Marti Wong
2017/05/12 00:04:50
Done.
|
| mContainer.removeInfoBar(this); |
| } |
| return true; |
| @@ -168,6 +169,17 @@ public abstract class InfoBar implements InfoBarView { |
| return false; |
| } |
| + /** |
| + * Called when infobar is being removed. Give the chance to clean up any child UI that may |
|
mdjones
2017/05/11 17:08:24
"Called just before the Java infobar has begun hid
Marti Wong
2017/05/12 00:04:50
Done.
|
| + * remain open. |
| + */ |
| + protected void onStartedRemoving() {} |
| + |
| + /** |
| + * Performs some action related to either the primary or secondary button being pressed. |
| + * @param isPrimaryButton True if the primary button was clicked, false otherwise. |
| + */ |
|
mdjones
2017/05/11 17:08:24
Remove this floating javadoc.
Marti Wong
2017/05/12 00:04:50
Done. sorry for the carelessness.
|
| + |
| long getNativeInfoBarPtr() { |
| return mNativeInfoBarPtr; |
| } |