Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: chrome/browser/ui/webui/engagement/site_engagement_ui.cc

Issue 2871473002: Use OnceCallback on Mojo interfaces in //chrome/browser/ui/webui/engagement
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/engagement/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/engagement/site_engagement_ui.h" 5 #include "chrome/browser/ui/webui/engagement/site_engagement_ui.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 19 matching lines...) Expand all
30 Profile* profile, 30 Profile* profile,
31 mojo::InterfaceRequest<mojom::SiteEngagementDetailsProvider> request) 31 mojo::InterfaceRequest<mojom::SiteEngagementDetailsProvider> request)
32 : profile_(profile), binding_(this, std::move(request)) { 32 : profile_(profile), binding_(this, std::move(request)) {
33 DCHECK(profile_); 33 DCHECK(profile_);
34 } 34 }
35 35
36 ~SiteEngagementDetailsProviderImpl() override {} 36 ~SiteEngagementDetailsProviderImpl() override {}
37 37
38 // mojom::SiteEngagementDetailsProvider overrides: 38 // mojom::SiteEngagementDetailsProvider overrides:
39 void GetSiteEngagementDetails( 39 void GetSiteEngagementDetails(
40 const GetSiteEngagementDetailsCallback& callback) override { 40 GetSiteEngagementDetailsCallback callback) override {
41 SiteEngagementService* service = SiteEngagementService::Get(profile_); 41 SiteEngagementService* service = SiteEngagementService::Get(profile_);
42 std::vector<mojom::SiteEngagementDetails> scores = service->GetAllDetails(); 42 std::vector<mojom::SiteEngagementDetails> scores = service->GetAllDetails();
43 43
44 std::vector<mojom::SiteEngagementDetailsPtr> engagement_info; 44 std::vector<mojom::SiteEngagementDetailsPtr> engagement_info;
45 engagement_info.reserve(scores.size()); 45 engagement_info.reserve(scores.size());
46 for (const auto& info : scores) { 46 for (const auto& info : scores) {
47 mojom::SiteEngagementDetailsPtr origin_info( 47 mojom::SiteEngagementDetailsPtr origin_info(
48 mojom::SiteEngagementDetails::New()); 48 mojom::SiteEngagementDetails::New());
49 *origin_info = std::move(info); 49 *origin_info = std::move(info);
50 engagement_info.push_back(std::move(origin_info)); 50 engagement_info.push_back(std::move(origin_info));
51 } 51 }
52 52
53 callback.Run(std::move(engagement_info)); 53 std::move(callback).Run(std::move(engagement_info));
54 } 54 }
55 55
56 void SetSiteEngagementBaseScoreForUrl(const GURL& origin, 56 void SetSiteEngagementBaseScoreForUrl(const GURL& origin,
57 double score) override { 57 double score) override {
58 if (!origin.is_valid() || score < 0 || 58 if (!origin.is_valid() || score < 0 ||
59 score > SiteEngagementService::GetMaxPoints() || std::isnan(score)) { 59 score > SiteEngagementService::GetMaxPoints() || std::isnan(score)) {
60 return; 60 return;
61 } 61 }
62 62
63 SiteEngagementService* service = SiteEngagementService::Get(profile_); 63 SiteEngagementService* service = SiteEngagementService::Get(profile_);
(...skipping 27 matching lines...) Expand all
91 } 91 }
92 92
93 SiteEngagementUI::~SiteEngagementUI() {} 93 SiteEngagementUI::~SiteEngagementUI() {}
94 94
95 void SiteEngagementUI::BindUIHandler( 95 void SiteEngagementUI::BindUIHandler(
96 const service_manager::BindSourceInfo& source_info, 96 const service_manager::BindSourceInfo& source_info,
97 mojom::SiteEngagementDetailsProviderRequest request) { 97 mojom::SiteEngagementDetailsProviderRequest request) {
98 ui_handler_.reset(new SiteEngagementDetailsProviderImpl( 98 ui_handler_.reset(new SiteEngagementDetailsProviderImpl(
99 Profile::FromWebUI(web_ui()), std::move(request))); 99 Profile::FromWebUI(web_ui()), std::move(request)));
100 } 100 }
OLDNEW
« no previous file with comments | « chrome/browser/engagement/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698