Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2871453002: Delete widget tree (FrameView::parent_) (Closed)

Created:
3 years, 7 months ago by joelhockey
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, jchaffraix+rendering, blink-reviews, blink-reviews-frames_chromium.org, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete widget tree (FrameView::parent_) Currently the calls to FrameView (FrameOrPlugin) Parent / SetParent create a tree of FrameView objects that maps 1:1 to Frame::Tree. These methods are removed and the frame tree is used. SetParent has been replaced with methods to notify FrameOrPlugin objects when they are attached or detached from the layout tree. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : rebase-update #

Patch Set 3 : upstream to origin/master to stop bad merges #

Patch Set 4 : Testing #

Patch Set 5 : Test recording state of objects #

Patch Set 6 : Test with FrameOrPluginState #

Patch Set 7 : FramOrPluginState #

Patch Set 8 : test with FrameOrPluginState #

Patch Set 9 : in progress #

Patch Set 10 : in progress #

Patch Set 11 : Debug information with FrameOrPluginState checking all operations. #

Patch Set 12 : Remove deferred state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -62 lines) Patch
M third_party/WebKit/Source/core/frame/FrameOrPlugin.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 8 9 10 11 15 chunks +110 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrameView.h View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrameView.cpp View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +92 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +20 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/plugins/PluginView.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 14 chunks +105 lines, -24 lines 0 comments Download

Messages

Total messages: 41 (41 generated)
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 04:45:28 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/1
3 years, 7 months ago (2017-05-08 04:45:57 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 04:49:50 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/262571) linux_chromium_compile_dbg_ng on ...
3 years, 7 months ago (2017-05-08 04:49:50 UTC) #4
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 04:59:18 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/20001
3 years, 7 months ago (2017-05-08 04:59:35 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 05:03:08 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/262525)
3 years, 7 months ago (2017-05-08 05:03:09 UTC) #8
joelhockey
Description was changed from ========== Delete widget tree (FrameView::parent_) Currently the calls to FrameView (FrameOrPlugin) ...
3 years, 7 months ago (2017-05-08 05:04:13 UTC) #9
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 05:04:31 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/40001
3 years, 7 months ago (2017-05-08 05:04:47 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 06:05:59 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/420376)
3 years, 7 months ago (2017-05-08 06:06:00 UTC) #13
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-11 06:37:16 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/60001
3 years, 7 months ago (2017-05-11 06:38:15 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-11 06:43:32 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/266528) android_compile_dbg on ...
3 years, 7 months ago (2017-05-11 06:43:33 UTC) #17
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-11 06:57:54 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/80001
3 years, 7 months ago (2017-05-11 06:58:30 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-11 07:27:38 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/365485)
3 years, 7 months ago (2017-05-11 07:27:38 UTC) #21
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-11 08:10:38 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/100001
3 years, 7 months ago (2017-05-11 08:11:11 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-11 08:47:56 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/365527)
3 years, 7 months ago (2017-05-11 08:47:57 UTC) #25
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-11 08:58:31 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/120001
3 years, 7 months ago (2017-05-11 08:59:20 UTC) #27
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-11 09:01:04 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/140001
3 years, 7 months ago (2017-05-11 09:01:23 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-11 09:47:49 UTC) #30
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/365574)
3 years, 7 months ago (2017-05-11 09:47:50 UTC) #31
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-12 07:34:01 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/160001
3 years, 7 months ago (2017-05-12 07:34:19 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-12 08:53:39 UTC) #34
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/369115)
3 years, 7 months ago (2017-05-12 08:53:40 UTC) #35
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-12 11:16:33 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871453002/180001
3 years, 7 months ago (2017-05-12 11:16:44 UTC) #37
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-12 12:58:50 UTC) #38
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-12 12:58:51 UTC) #39
joelhockey
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-14 22:08:15 UTC) #40
commit-bot: I haz the power
3 years, 7 months ago (2017-05-14 22:08:24 UTC) #41

Powered by Google App Engine
This is Rietveld 408576698